Re: [PATCH 3/5] drm/amdgpu: fix lru size grouping

2016-08-18 Thread Felix Kuehling
OK. Feel free to add my Reviewed-by. On 16-08-18 03:54 AM, Christian König wrote: >> /* custom LRU management */ >> struct amdgpu_mman_lrulog2_size[AMDGPU_TTM_LRU_SIZE]; >> +struct amdgpu_mman_lruguard; >> [FK] It would be safer to make the array AMDGPU_TTM

Re: [PATCH 3/5] drm/amdgpu: fix lru size grouping

2016-08-18 Thread Christian König
/* custom LRU management */ struct amdgpu_mman_lru log2_size[AMDGPU_TTM_LRU_SIZE]; + struct amdgpu_mman_lru guard; [FK] It would be safer to make the array AMDGPU_TTM_LRU_SIZE+1, instead of adding a separate guard afterwards. That way the gua

Re: [PATCH 3/5] drm/amdgpu: fix lru size grouping

2016-08-17 Thread Felix Kuehling
One suggestion inline [FK]. With that fixed, Reviewed-by: Felix Kuehling Regards, Felix On 16-08-17 08:26 AM, Christian König wrote: > From: Christian König > > Adding a BO can make it the insertion point for larger sizes as well. > > Signed-off-by: Christian König > --- > drivers/gpu/drm

[PATCH 3/5] drm/amdgpu: fix lru size grouping

2016-08-17 Thread Christian König
From: Christian König Adding a BO can make it the insertion point for larger sizes as well. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 2 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/amd