Re: [PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

2021-03-09 Thread Michel Dänzer
On 2021-03-08 9:38 p.m., Kazlauskas, Nicholas wrote: > On 2021-03-08 3:18 p.m., Daniel Vetter wrote: >> On Fri, Mar 5, 2021 at 10:24 AM Michel Dänzer wrote: >>> >>> On 2021-03-04 7:26 p.m., Kazlauskas, Nicholas wrote: It's a little odd that a disable commit can fail, but I don't think >>

Re: [PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

2021-03-08 Thread Kazlauskas, Nicholas
On 2021-03-08 3:18 p.m., Daniel Vetter wrote: On Fri, Mar 5, 2021 at 10:24 AM Michel Dänzer wrote: On 2021-03-04 7:26 p.m., Kazlauskas, Nicholas wrote: On 2021-03-04 10:35 a.m., Michel Dänzer wrote: On 2021-03-04 4:09 p.m., Kazlauskas, Nicholas wrote: On 2021-03-04 4:05 a.m., Michel Dänzer

Re: [PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

2021-03-08 Thread Daniel Vetter
On Fri, Mar 5, 2021 at 10:24 AM Michel Dänzer wrote: > > On 2021-03-04 7:26 p.m., Kazlauskas, Nicholas wrote: > > On 2021-03-04 10:35 a.m., Michel Dänzer wrote: > >> On 2021-03-04 4:09 p.m., Kazlauskas, Nicholas wrote: > >>> On 2021-03-04 4:05 a.m., Michel Dänzer wrote: > On 2021-03-03 8:17 p

Re: [PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

2021-03-05 Thread Michel Dänzer
On 2021-03-04 7:26 p.m., Kazlauskas, Nicholas wrote: > On 2021-03-04 10:35 a.m., Michel Dänzer wrote: >> On 2021-03-04 4:09 p.m., Kazlauskas, Nicholas wrote: >>> On 2021-03-04 4:05 a.m., Michel Dänzer wrote: On 2021-03-03 8:17 p.m., Daniel Vetter wrote: > On Wed, Mar 3, 2021 at 5:53 PM Mic

Re: [PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

2021-03-04 Thread Kazlauskas, Nicholas
On 2021-03-04 10:35 a.m., Michel Dänzer wrote: On 2021-03-04 4:09 p.m., Kazlauskas, Nicholas wrote: On 2021-03-04 4:05 a.m., Michel Dänzer wrote: On 2021-03-03 8:17 p.m., Daniel Vetter wrote: On Wed, Mar 3, 2021 at 5:53 PM Michel Dänzer wrote: Moreover, in the same scenario plus an overlay

Re: [PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

2021-03-04 Thread Michel Dänzer
On 2021-03-04 4:09 p.m., Kazlauskas, Nicholas wrote: > On 2021-03-04 4:05 a.m., Michel Dänzer wrote: >> On 2021-03-03 8:17 p.m., Daniel Vetter wrote: >>> On Wed, Mar 3, 2021 at 5:53 PM Michel Dänzer wrote: Moreover, in the same scenario plus an overlay plane enabled with a HW cursor

Re: [PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

2021-03-04 Thread Kazlauskas, Nicholas
On 2021-03-04 4:05 a.m., Michel Dänzer wrote: On 2021-03-03 8:17 p.m., Daniel Vetter wrote: On Wed, Mar 3, 2021 at 5:53 PM Michel Dänzer wrote: On 2021-02-19 7:58 p.m., Simon Ser wrote: Make sure there's an underlying pipe that can be used for the cursor. Signed-off-by: Simon Ser Cc: Alex

Re: [PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

2021-03-04 Thread Michel Dänzer
On 2021-03-03 8:17 p.m., Daniel Vetter wrote: On Wed, Mar 3, 2021 at 5:53 PM Michel Dänzer wrote: On 2021-02-19 7:58 p.m., Simon Ser wrote: Make sure there's an underlying pipe that can be used for the cursor. Signed-off-by: Simon Ser Cc: Alex Deucher Cc: Harry Wentland Cc: Nicholas Kazla

Re: [PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

2021-03-03 Thread Daniel Vetter
On Wed, Mar 3, 2021 at 5:53 PM Michel Dänzer wrote: > > On 2021-02-19 7:58 p.m., Simon Ser wrote: > > Make sure there's an underlying pipe that can be used for the > > cursor. > > > > Signed-off-by: Simon Ser > > Cc: Alex Deucher > > Cc: Harry Wentland > > Cc: Nicholas Kazlauskas > > --- > >

Re: [PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

2021-03-03 Thread Michel Dänzer
On 2021-02-19 7:58 p.m., Simon Ser wrote: Make sure there's an underlying pipe that can be used for the cursor. Signed-off-by: Simon Ser Cc: Alex Deucher Cc: Harry Wentland Cc: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++- 1 file changed, 6 inserti

[PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

2021-02-19 Thread Simon Ser
Make sure there's an underlying pipe that can be used for the cursor. Signed-off-by: Simon Ser Cc: Alex Deucher Cc: Harry Wentland Cc: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gp