RE: [PATCH 3/7] drm/amd/pm: drop the redundant 'supported' member of smu_feature structure

2022-01-25 Thread Quan, Evan
5:37 PM > >> To: Quan, Evan ; amd-gfx@lists.freedesktop.org > >> Cc: Deucher, Alexander ; Chen, Guchun > >> ; Huang, Ray > >> Subject: Re: [PATCH 3/7] drm/amd/pm: drop the redundant 'supported' > >> member of smu_feature structure > >> > &g

Re: [PATCH 3/7] drm/amd/pm: drop the redundant 'supported' member of smu_feature structure

2022-01-23 Thread Lazar, Lijo
; Huang, Ray Subject: Re: [PATCH 3/7] drm/amd/pm: drop the redundant 'supported' member of smu_feature structure On 1/21/2022 1:14 PM, Evan Quan wrote: As it has exactly the same value as the 'enabled' member and also do the same thing. I believe the original intention is different. We need

RE: [PATCH 3/7] drm/amd/pm: drop the redundant 'supported' member of smu_feature structure

2022-01-23 Thread Quan, Evan
4:52 PM > >> To: Quan, Evan ; amd-gfx@lists.freedesktop.org > >> Cc: Deucher, Alexander ; Chen, Guchun > >> ; Huang, Ray > >> Subject: Re: [PATCH 3/7] drm/amd/pm: drop the redundant 'supported' > >> member of smu_feature structure > >> > >

Re: [PATCH 3/7] drm/amd/pm: drop the redundant 'supported' member of smu_feature structure

2022-01-21 Thread Lazar, Lijo
On 1/21/2022 2:56 PM, Quan, Evan wrote: [AMD Official Use Only] -Original Message- From: Lazar, Lijo Sent: Friday, January 21, 2022 4:52 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Chen, Guchun ; Huang, Ray Subject: Re: [PATCH 3/7] drm/amd/pm: drop

RE: [PATCH 3/7] drm/amd/pm: drop the redundant 'supported' member of smu_feature structure

2022-01-21 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Friday, January 21, 2022 4:52 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Chen, Guchun > ; Huang, Ray > Subject: Re: [PATCH 3/7] drm/amd/pm: drop the

Re: [PATCH 3/7] drm/amd/pm: drop the redundant 'supported' member of smu_feature structure

2022-01-21 Thread Lazar, Lijo
On 1/21/2022 1:14 PM, Evan Quan wrote: As it has exactly the same value as the 'enabled' member and also do the same thing. I believe the original intention is different. We need to cache the features which are really supported by PMFW on that device on init. When a request comes through

[PATCH 3/7] drm/amd/pm: drop the redundant 'supported' member of smu_feature structure

2022-01-20 Thread Evan Quan
As it has exactly the same value as the 'enabled' member and also do the same thing. Signed-off-by: Evan Quan Change-Id: I07c9a5ac5290cd0d88a40ce1768d393156419b5a --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 1 - drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 1 -