Re: [PATCH 4/4] drm/amd/powerplay: put those exposed power interfaces in amdgpu_dpm.c

2020-08-14 Thread Nirmoy
2020 9:54 PM To: Das, Nirmoy Cc: Quan, Evan ; amd-gfx list ; Deucher, Alexander Subject: Re: [PATCH 4/4] drm/amd/powerplay: put those exposed power interfaces in amdgpu_dpm.c Series is: Reviewed-by: Alex Deucher Nirmoy makes some good points below, but I think those should be a follow up pat

RE: [PATCH 4/4] drm/amd/powerplay: put those exposed power interfaces in amdgpu_dpm.c

2020-08-13 Thread Quan, Evan
list ; Deucher, Alexander Subject: Re: [PATCH 4/4] drm/amd/powerplay: put those exposed power interfaces in amdgpu_dpm.c Series is: Reviewed-by: Alex Deucher Nirmoy makes some good points below, but I think those should be a follow up patch as this patch is just moving code around; no actual ch

Re: [PATCH 4/4] drm/amd/powerplay: put those exposed power interfaces in amdgpu_dpm.c

2020-08-13 Thread Alex Deucher
Series is: Reviewed-by: Alex Deucher Nirmoy makes some good points below, but I think those should be a follow up patch as this patch is just moving code around; no actual changes. Alex On Thu, Aug 13, 2020 at 6:52 AM Nirmoy wrote: > > Acked-by: Nirmoy Das for 1st 3 patches. Check for > below

Re: [PATCH 4/4] drm/amd/powerplay: put those exposed power interfaces in amdgpu_dpm.c

2020-08-13 Thread Nirmoy
Acked-by: Nirmoy Das for 1st 3 patches. Check for below for more comments. On 8/13/20 11:08 AM, Evan Quan wrote: As other power interfaces. Change-Id: I5e3b85ae21c4b1d0239f54fa75247b33cfdb7ddc Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 425 +

[PATCH 4/4] drm/amd/powerplay: put those exposed power interfaces in amdgpu_dpm.c

2020-08-13 Thread Evan Quan
As other power interfaces. Change-Id: I5e3b85ae21c4b1d0239f54fa75247b33cfdb7ddc Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 425 drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 14 + drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 423