-
From: Kuehling, Felix
Sent: Monday, June 3, 2019 6:27 PM
To: Zeng, Oak ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/amdkfd: Fix a circular lock dependency
allocate_vmid, allocate_hqd and allocate_sdma_queue all work on data in the DQM
structure. So it seems these need
allocate_vmid, allocate_hqd and allocate_sdma_queue all work on data in
the DQM structure. So it seems these need to be protected by the DQM
lock. allocate_doorbell doesn't need the DQM lock because its data
structures are in the process_device structure, which is protected by
the process
The idea to break the circular lock dependency is
to move init_mqd out of lock protection of dqm lock
in callstack #1 below. There is no need to.
[ 59.510149] [drm] Initialized amdgpu 3.30.0 20150101 for :04:00.0 on
minor 0
[ 513.604034]
