Re: [PATCH 6/6] drm/amdgpu/sienna_cichlid: add SMU i2c support (v2)

2020-07-21 Thread Andrey Grodzovsky
Series is Reviewed-by: Andrey Grodzovsky Andrey On 7/21/20 2:08 PM, Alex Deucher wrote: Enable SMU i2c bus access for sienna_cichlid asics. v2: change callback name Signed-off-by: Alex Deucher --- .../drm/amd/powerplay/sienna_cichlid_ppt.c| 239 ++ 1 file changed,

[PATCH 6/6] drm/amdgpu/sienna_cichlid: add SMU i2c support (v2)

2020-07-21 Thread Alex Deucher
Enable SMU i2c bus access for sienna_cichlid asics. v2: change callback name Signed-off-by: Alex Deucher --- .../drm/amd/powerplay/sienna_cichlid_ppt.c| 239 ++ 1 file changed, 239 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c

Re: [PATCH 6/6] drm/amdgpu/sienna_cichlid: add SMU i2c support

2020-07-21 Thread Andrey Grodzovsky
Series besides patch 5/6 which you said is the wrong version is Reviewed-by: Andrey Grodzovsky Andrey On 7/21/20 12:52 PM, Alex Deucher wrote: Enable SMU i2c bus access for sienna_cichlid asics. Signed-off-by: Alex Deucher --- .../drm/amd/powerplay/sienna_cichlid_ppt.c| 239

Re: [PATCH 6/6] drm/amdgpu/sienna_cichlid: add SMU i2c support

2020-07-21 Thread Deucher, Alexander
: Deucher, Alexander Subject: Re: [PATCH 6/6] drm/amdgpu/sienna_cichlid: add SMU i2c support Looks like same code as arcturus - should we make it common helper code and reuse in both ? Andrey On 7/21/20 12:52 PM, Alex Deucher wrote: > Enable SMU i2c bus access for sienna_cichlid asics. > &g

Re: [PATCH 6/6] drm/amdgpu/sienna_cichlid: add SMU i2c support

2020-07-21 Thread Andrey Grodzovsky
Looks like same code as arcturus - should we make it common helper code and reuse in both ? Andrey On 7/21/20 12:52 PM, Alex Deucher wrote: Enable SMU i2c bus access for sienna_cichlid asics. Signed-off-by: Alex Deucher --- .../drm/amd/powerplay/sienna_cichlid_ppt.c| 239

[PATCH 6/6] drm/amdgpu/sienna_cichlid: add SMU i2c support

2020-07-21 Thread Alex Deucher
Enable SMU i2c bus access for sienna_cichlid asics. Signed-off-by: Alex Deucher --- .../drm/amd/powerplay/sienna_cichlid_ppt.c| 239 ++ 1 file changed, 239 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c