Re: [PATCH 7/7] drm/amdgpu: drop testing module parameter

2022-02-22 Thread Christian König
Am 22.02.22 um 10:07 schrieb Michel Dänzer: On 2022-02-21 22:35, Alex Deucher wrote: On Mon, Feb 21, 2022 at 12:44 PM Michel Dänzer wrote: On 2022-02-18 23:26, Alex Deucher wrote: This was always duplicate functionality with the benchmark tests. Not really. The purpose of

Re: [PATCH 7/7] drm/amdgpu: drop testing module parameter

2022-02-22 Thread Michel Dänzer
On 2022-02-21 22:35, Alex Deucher wrote: > On Mon, Feb 21, 2022 at 12:44 PM Michel Dänzer > wrote: >> >> On 2022-02-18 23:26, Alex Deucher wrote: >>> This was always duplicate functionality with the benchmark tests. >> >> Not really. The purpose of amdgpu_do_test_moves is testing that copies >>

Re: [PATCH 7/7] drm/amdgpu: drop testing module parameter

2022-02-21 Thread Alex Deucher
On Mon, Feb 21, 2022 at 12:44 PM Michel Dänzer wrote: > > On 2022-02-18 23:26, Alex Deucher wrote: > > This was always duplicate functionality with the benchmark tests. > > Not really. The purpose of amdgpu_do_test_moves is testing that copies > between GTT & VRAM work across the whole GTT

Re: [PATCH 7/7] drm/amdgpu: drop testing module parameter

2022-02-21 Thread Michel Dänzer
On 2022-02-18 23:26, Alex Deucher wrote: > This was always duplicate functionality with the benchmark tests. Not really. The purpose of amdgpu_do_test_moves is testing that copies between GTT & VRAM work across the whole GTT aperture (when I originally wrote radeon_do_test_moves, they didn't on

[PATCH 7/7] drm/amdgpu: drop testing module parameter

2022-02-18 Thread Alex Deucher
This was always duplicate functionality with the benchmark tests. Drop it. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 7 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 -