RE: [PATCH V2 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-26 Thread Quan, Evan
tely we need some follow up patches if we want this done in a more generic way. BR Evan From: Deucher, Alexander Sent: Friday, July 23, 2021 9:36 PM To: Lazar, Lijo ; Quan, Evan ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH V2 1/2] drm/amd/pm: restore user customized OD settings properly

RE: [PATCH V2 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-26 Thread Quan, Evan
for this. BR Evan > -Original Message- > From: Chen, Guchun > Sent: Friday, July 23, 2021 9:45 PM > To: Lazar, Lijo ; Quan, Evan ; > amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: RE: [PATCH V2 1/2] drm/amd/pm: restore user customized OD >

Re: [PATCH V2 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-23 Thread Lazar, Lijo
md-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH V2 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x The series looks good to me, though I prefer to use a common logic to restore od settings so that smuv12,smuv13 gets the restore feature by default once they a

RE: [PATCH V2 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-23 Thread Chen, Guchun
xander Subject: Re: [PATCH V2 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x The series looks good to me, though I prefer to use a common logic to restore od settings so that smuv12,smuv13 gets the restore feature by default once they add the user table logic. Don&

Re: [PATCH V2 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-23 Thread Deucher, Alexander
; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH V2 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x The series looks good to me, though I prefer to use a common logic to restore od settings so that smuv12,smuv13 gets the restore feature by default

Re: [PATCH V2 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-23 Thread Lazar, Lijo
The series looks good to me, though I prefer to use a common logic to restore od settings so that smuv12,smuv13 gets the restore feature by default once they add the user table logic. Don't have strong argument for it unless Alex, Kenneth or others have some comments. Anyway, the series is

[PATCH V2 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-23 Thread Evan Quan
The customized OD settings can be divided into two parts: those committed ones and non-committed ones. - For those changes which had been fed to SMU before S3/S4/Runpm suspend kicked, they are committed changes. They should be properly restored and fed to SMU on S3/S4/Runpm resume. - Fo