RE: [PATCH V2 1/7] drm/amd/pm: drop unneeded lock protection smu->mutex

2022-01-20 Thread Quan, Evan
[Public] > -Original Message- > From: Chen, Guchun > Sent: Thursday, January 20, 2022 9:38 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Lazar, Lijo > > Subject: RE: [PATCH V2 1/7] drm/amd/pm: drop unneeded lock protection >

RE: [PATCH V2 1/7] drm/amd/pm: drop unneeded lock protection smu->mutex

2022-01-20 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, January 20, 2022 11:23 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Chen, Guchun > > Subject: Re: [PATCH V2 1/7] drm/amd/pm: drop unneeded lock pr

Re: [PATCH V2 1/7] drm/amd/pm: drop unneeded lock protection smu->mutex

2022-01-20 Thread Lazar, Lijo
Apart from patch 1, rest of the series is Reviewed-by: Lijo Lazar Patch 1 needs another look related to i2c transfers. Thanks, Lijo On 1/17/2022 11:11 AM, Evan Quan wrote: As all those APIs are already protected either by adev->pm.mutex or smu->message_lock. Signed-off-by: Evan Quan

Re: [PATCH V2 1/7] drm/amd/pm: drop unneeded lock protection smu->mutex

2022-01-20 Thread Lazar, Lijo
On 1/17/2022 11:11 AM, Evan Quan wrote: As all those APIs are already protected either by adev->pm.mutex or smu->message_lock. Signed-off-by: Evan Quan Change-Id: I1db751fba9caabc5ca1314992961d3674212f9b0 --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 315 ++

RE: [PATCH V2 1/7] drm/amd/pm: drop unneeded lock protection smu->mutex

2022-01-20 Thread Chen, Guchun
return -ENOMEM; } Regards, Guchun -Original Message- From: Quan, Evan Sent: Monday, January 17, 2022 1:42 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar, Lijo ; Chen, Guchun ; Quan, Evan Subject: [PATCH V2 1/7] drm/amd/pm: drop unneeded lock protection smu->

[PATCH V2 1/7] drm/amd/pm: drop unneeded lock protection smu->mutex

2022-01-16 Thread Evan Quan
As all those APIs are already protected either by adev->pm.mutex or smu->message_lock. Signed-off-by: Evan Quan Change-Id: I1db751fba9caabc5ca1314992961d3674212f9b0 --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 315 ++ drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 1 -