Re: [PATCH libdrm] amdgpu: add a function to create amdgpu bo internally (v4)

On 08/13/2018 06:14 PM, Christian König wrote: Am 13.08.2018 um 12:06 schrieb Junwei Zhang: a helper function to create and initialize amdgpu bo v2: update error handling: add label and free bo v3: update error handling: separate each error label v4: update error handling and free flink bo in

Re: [PATCH libdrm] amdgpu: add a function to create amdgpu bo internally (v4)

Am 13.08.2018 um 12:06 schrieb Junwei Zhang: a helper function to create and initialize amdgpu bo v2: update error handling: add label and free bo v3: update error handling: separate each error label v4: update error handling and free flink bo in bo import Signed-off-by: Junwei Zhang A

[PATCH libdrm] amdgpu: add a function to create amdgpu bo internally (v4)

a helper function to create and initialize amdgpu bo v2: update error handling: add label and free bo v3: update error handling: separate each error label v4: update error handling and free flink bo in bo import Signed-off-by: Junwei Zhang --- amdgpu/amdgpu_bo.c | 208

[PATCH libdrm] amdgpu: add a function to create amdgpu bo internally (v3)

a helper function to create and initialize amdgpu bo v2: update error handling: add label and free bo v3: update error handling: separate each error label Signed-off-by: Junwei Zhang --- amdgpu/amdgpu_bo.c | 196 ++--- 1 file changed, 95

Re: [PATCH libdrm] amdgpu: add a function to create amdgpu bo internally (v2)

Am 09.08.2018 um 11:29 schrieb Junwei Zhang: a helper function to create and initialize amdgpu bo v2: update error handling: add label and free bo Signed-off-by: Junwei Zhang --- amdgpu/amdgpu_bo.c | 186 + 1 file changed, 89

[PATCH libdrm] amdgpu: add a function to create amdgpu bo internally (v2)

a helper function to create and initialize amdgpu bo v2: update error handling: add label and free bo Signed-off-by: Junwei Zhang --- amdgpu/amdgpu_bo.c | 186 + 1 file changed, 89 insertions(+), 97 deletions(-) diff --git

RE: [PATCH libdrm] amdgpu: add a function to create amdgpu bo internally

> > > > + r = amdgpu_bo_create(dev, alloc_buffer->alloc_size, args.out.handle, > > +buf_handle); > > if (r) > > - amdgpu_bo_free(bo); > > - else > > - *buf_handle = bo; > > + goto out; > > [yuq] the handle

Re: [PATCH libdrm] amdgpu: add a function to create amdgpu bo internally

> + r = amdgpu_bo_create(dev, alloc_buffer->alloc_size, args.out.handle, > +buf_handle); > if (r) > - amdgpu_bo_free(bo); > - else > - *buf_handle = bo; > + goto out; > [yuq] the handle is not freed. Do

Re: [PATCH libdrm] amdgpu: add a function to create amdgpu bo internally

] amdgpu: add a function to create amdgpu bo internally a helper function to create and initialize amdgpu bo Signed-off-by: Junwei Zhang --- amdgpu/amdgpu_bo.c | 184 - 1 file changed, 84 insertions(+), 100 deletions(-) diff --git a/amdgpu

Re: [PATCH libdrm] amdgpu: add a function to create amdgpu bo internally

Comments inline. Regards, Qiang From: amd-gfx on behalf of Junwei Zhang Sent: Thursday, August 9, 2018 11:19 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jerry; Koenig, Christian Subject: [PATCH libdrm] amdgpu: add a function to create amdgpu bo

Re: [PATCH libdrm] amdgpu: add a function to create amdgpu bo internally

Am 09.08.2018 um 05:19 schrieb Junwei Zhang: a helper function to create and initialize amdgpu bo Signed-off-by: Junwei Zhang --- amdgpu/amdgpu_bo.c | 184 - 1 file changed, 84 insertions(+), 100 deletions(-) diff --git

[PATCH libdrm] amdgpu: add a function to create amdgpu bo internally

a helper function to create and initialize amdgpu bo Signed-off-by: Junwei Zhang --- amdgpu/amdgpu_bo.c | 184 - 1 file changed, 84 insertions(+), 100 deletions(-) diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c index b790e9b..2cca40d