Re: [PATCH umr] Skip ahead if PDE entry is actually a PTE entry. (v2)

2017-11-06 Thread Christian König
Am 06.11.2017 um 19:39 schrieb Tom St Denis: On 06/11/17 01:34 PM, Christian König wrote: Am 06.11.2017 um 19:28 schrieb Tom St Denis: On 06/11/17 05:01 AM, Christian König wrote: Am 04.11.2017 um 18:15 schrieb Tom St Denis: Signed-off-by: Tom St Denis Still not perfect, but good enough fo

Re: [PATCH umr] Skip ahead if PDE entry is actually a PTE entry. (v2)

2017-11-06 Thread Tom St Denis
On 06/11/17 01:34 PM, Christian König wrote: Am 06.11.2017 um 19:28 schrieb Tom St Denis: On 06/11/17 05:01 AM, Christian König wrote: Am 04.11.2017 um 18:15 schrieb Tom St Denis: Signed-off-by: Tom St Denis Still not perfect, but good enough for now. Patch is Tested-by: Christian König .

Re: [PATCH umr] Skip ahead if PDE entry is actually a PTE entry. (v2)

2017-11-06 Thread Christian König
Am 06.11.2017 um 19:28 schrieb Tom St Denis: On 06/11/17 05:01 AM, Christian König wrote: Am 04.11.2017 um 18:15 schrieb Tom St Denis: Signed-off-by: Tom St Denis Still not perfect, but good enough for now. Patch is Tested-by: Christian König . I think you need to rework the VM walking a

Re: [PATCH umr] Skip ahead if PDE entry is actually a PTE entry. (v2)

2017-11-06 Thread Tom St Denis
On 06/11/17 05:01 AM, Christian König wrote: Am 04.11.2017 um 18:15 schrieb Tom St Denis: Signed-off-by: Tom St Denis Still not perfect, but good enough for now. Patch is Tested-by: Christian König . I think you need to rework the VM walking a bit, cause we need to support the T bit as we

Re: [PATCH umr] Skip ahead if PDE entry is actually a PTE entry. (v2)

2017-11-06 Thread Christian König
Am 04.11.2017 um 18:15 schrieb Tom St Denis: Signed-off-by: Tom St Denis Still not perfect, but good enough for now. Patch is Tested-by: Christian König . I think you need to rework the VM walking a bit, cause we need to support the T bit as well in the future and your code make a few ass

[PATCH umr] Skip ahead if PDE entry is actually a PTE entry. (v2)

2017-11-04 Thread Tom St Denis
Signed-off-by: Tom St Denis (v2) Don't print out PDE entries with PTE bit set --- src/lib/read_vram.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/lib/read_vram.c b/src/lib/read_vram.c index 0df48dadec12..51823d71021e 100644 --- a/src/lib/read_vram.c +++ b/src/l

Re: [PATCH umr] Skip ahead if PDE entry is actually a PTE entry.

2017-11-04 Thread Christian König
Close, but not perfect. Reading an address seem to work, but the --vm-decode output is a bit confusing: [VERBOSE]: PDE0=0x0003fefff001, VA=0x, PBA==0x0003fefff000, V=1, S=0, C=0, P=0 [VERBOSE]:    \-> PDE1=0x0003feffe001, VA=0x4000, PBA==0x0003feffe000, V=1, S=0, C=

[PATCH umr] Skip ahead if PDE entry is actually a PTE entry.

2017-11-03 Thread Tom St Denis
Signed-off-by: Tom St Denis --- src/lib/read_vram.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/lib/read_vram.c b/src/lib/read_vram.c index 0df48dadec12..5d9523476e25 100644 --- a/src/lib/read_vram.c +++ b/src/lib/read_vram.c @@ -522,6 +522,11 @@ static int umr_access_vram_ai(st