RE: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode

2021-03-10 Thread Zhang, Jack (Jian)
@lists.freedesktop.org; Deng, Emily Subject: Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode Yeah, sorry. I've seen your reply only after I wrote this mail. I think we can go ahead if you don't have much other concern on this. Christian. Am 09.03.21 um 17:48 schrieb Andrey Grodzovsky:

Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode

2021-03-09 Thread Christian König
-Original Message- From: Koenig, Christian Sent: Monday, March 8, 2021 3:53 PM To: Liu, Monk ; Zhang, Jack (Jian) ; amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Deng, Emily Subject: Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode

Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode

2021-03-09 Thread Andrey Grodzovsky
Liu | Cloud-GPU Core team -- -Original Message- From: Koenig, Christian Sent: Sunday, March 7, 2021 3:03 AM To: Zhang, Jack (Jian) ; amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Liu, Monk ; Deng, Emily Subject: Re: [PATCH v2] drm/amd/amdgpu imp

Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode

2021-03-09 Thread Christian König
onk ; Zhang, Jack (Jian) ; amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Deng, Emily Subject: Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode Am 08.03.21 um 05:06 schrieb Liu, Monk: [AMD Official Use Only - Internal Distribution Only] well first of all please completely drop the affini

RE: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode

2021-03-08 Thread Liu, Monk
p.org; Grodzovsky, Andrey ; Deng, Emily Subject: Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode Am 08.03.21 um 05:06 schrieb Liu, Monk: > [AMD Official Use Only - Internal Distribution Only] > >>> well first of all please completely drop the affinity group stuff from this

RE: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode

2021-03-08 Thread Zhang, Jack (Jian)
oblem. Thanks, Jack -Original Message- From: Koenig, Christian Sent: Monday, March 8, 2021 8:45 PM To: Zhang, Jack (Jian) ; Liu, Monk ; amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Deng, Emily Subject: Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode Hi Jack, yes that

Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode

2021-03-08 Thread Christian König
PM To: Liu, Monk ; Zhang, Jack (Jian) ; amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Deng, Emily Subject: Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode Am 08.03.21 um 05:06 schrieb Liu, Monk: [AMD Official Use Only - Internal Distribution Only] well first of all p

RE: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode

2021-03-08 Thread Zhang, Jack (Jian)
: Monday, March 8, 2021 3:53 PM To: Liu, Monk ; Zhang, Jack (Jian) ; amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Deng, Emily Subject: Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode Am 08.03.21 um 05:06 schrieb Liu, Monk: > [AMD Official Use Only - Internal Distribution O

Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode

2021-03-07 Thread Christian König
ent: Sunday, March 7, 2021 3:03 AM To: Zhang, Jack (Jian) ; amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Liu, Monk ; Deng, Emily Subject: Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode Hi Jack, well first of all please completely drop the affinity group stuff from this patch. We

RE: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode

2021-03-07 Thread Zhang, Jack (Jian)
) ; amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Deng, Emily Subject: RE: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode [AMD Official Use Only - Internal Distribution Only] >> well first of all please completely drop the affinity group stuff from this >> patch. We should conce

RE: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode

2021-03-07 Thread Liu, Monk
-GPU Core team -- -Original Message- From: Koenig, Christian Sent: Sunday, March 7, 2021 3:03 AM To: Zhang, Jack (Jian) ; amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Liu, Monk ; Deng, Emily Subject: Re: [PATCH v2] drm/amd/amdgpu implement

Re: [PATCH v2] drm/amd/amdgpu implement tdr advanced mode

2021-03-06 Thread Christian König
Hi Jack, well first of all please completely drop the affinity group stuff from this patch. We should concentrate on one feature at at time. Then the implementation is way to complicate. All you need to do is insert a dma_fence_wait after re-scheduling each job after a reset. Additional to

[PATCH v2] drm/amd/amdgpu implement tdr advanced mode

2021-03-06 Thread Jack Zhang
[Why] Previous tdr design treats the first job in job_timeout as the bad job. But sometimes a later bad compute job can block a good gfx job and cause an unexpected gfx job timeout because gfx and compute ring share internal GC HW mutually. [How] This patch implements an advanced tdr mode.It invol