Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-23 Thread Rino André Johnsen
To be perfectly honest with you, I haven't given that much though. I used the 'bpc' and 'colorspace' property in debugfs, since I could not find that information anywhere else. And since I also needed to verify the pixel encoding being used, I added it where those other values were. That made for

Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-23 Thread Rino André Johnsen
Looked through the patch series from Andri Yngvason and that does exactly what I wanted in the first place. I think that the patch series should be encouraged to be merged in as fast as possible. For the patch I have submitted, it stands on its own, since the patch series from Andri Yngvason does

Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-22 Thread Simon Ser
On Wednesday, May 22nd, 2024 at 15:36, Mario Limonciello wrote: > > To be perfectly honest with you, I haven't given that much though. I > > used the 'bpc' and 'colorspace' property in debugfs, since I could not > > find that information anywhere else. And since I also needed to verify > > the

Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-22 Thread Mario Limonciello
+ Simon On 5/22/2024 05:07, Rino André Johnsen wrote: To be perfectly honest with you, I haven't given that much though. I used the 'bpc' and 'colorspace' property in debugfs, since I could not find that information anywhere else. And since I also needed to verify the pixel encoding being used,

Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-22 Thread Rino André Johnsen
What is already there in debugfs is 'bpc' and 'colorspace', but not the pixel encoding/format. I have searched high and low for that to be able to verify that my monitor and computer are using my preferred combination of all those three values. I do think it should be available as a standard DRM

Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-21 Thread Mario Limonciello
On 5/21/2024 15:06, Rino André Johnsen wrote: What is already there in debugfs is 'bpc' and 'colorspace', but not the pixel encoding/format. I have searched high and low for that to be able to verify that my monitor and computer are using my preferred combination of all those three values. I do

Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-21 Thread Christian König
Am 21.05.24 um 07:11 schrieb Rino Andre Johnsen: [Why] For debugging and testing purposes. [How] Create amdgpu_current_pixelencoding debugfs entry. Usage: cat /sys/kernel/debug/dri/1/crtc-0/amdgpu_current_pixelencoding Why isn't that available as standard DRM CRTC property in either sysfs or

[PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-21 Thread Rino Andre Johnsen
[Why] For debugging and testing purposes. [How] Create amdgpu_current_pixelencoding debugfs entry. Usage: cat /sys/kernel/debug/dri/1/crtc-0/amdgpu_current_pixelencoding Signed-off-by: Rino Andre Johnsen --- Changes in v2: 1. Do not initialize dm_crtc_state to NULL. ---