Re: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-25 Thread Nathan Chancellor
On Thu, May 25, 2023 at 08:37:07AM -0700, Kees Cook wrote: > Hi! > > On Wed, May 24, 2023 at 04:27:31PM -0400, Hamza Mahfooz wrote: > > + Kees > > > > On 5/24/23 15:50, Alex Deucher wrote: > > > On Wed, May 24, 2023 at 3:46 PM Felix Kuehling > > > wrote: > > > > > > > > Sure, I think we tried

Re: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-25 Thread Christoph Hellwig
> +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation We have a config option for -Werror. Blindly adding this will create problems with too new (or sometimes too old, or just too weird) compilers all the time. Don't do this.

Re: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-25 Thread Kees Cook
going to enable full kernel werror in the kconfig used by my CI but > > > > this is probably better. > > > > > > > > Kenny > > > > > > > > > > > > >

Re: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-25 Thread Jani Nikula
t;>> issues here? >>>> >>>> Kent >>>> >>>> *From:* amd-gfx *On Behalf Of >>>> *Ho, Kenny >>>> *Sent:* Wednesday, May 24, 2023 3:23 PM >>>> *To:* Alex Deucher ; Mahfooz, Hamza >>>> >>>> *Cc:*

Re: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-24 Thread Hamza Mahfooz
op.org; amd-gfx@lists.freedesktop.org; Daniel Vetter ; Deucher, Alexander ; David Airlie ; Koenig, Christian *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile checks [AMD Official Use Only - General] [AMD Official Use Only - General] (+ Felix) Should we do the same for other mo

Re: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-24 Thread Hamza Mahfooz
On 5/24/23 15:54, Harry Wentland wrote: On 5/24/23 15:27, Hamza Mahfooz wrote: On 5/24/23 15:22, Alex Deucher wrote: On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote: Currently, there are quite a number of issues that are quite easy for the CI to catch, that slip through the cracks. Amo

Re: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-24 Thread Ho, Kenny
: [PATCH v2] drm/amd/display: enable more strict compile checks On Wed, May 24, 2023 at 3:46 PM Felix Kuehling wrote: > > Sure, I think we tried enabling warnings as errors before and had to > revert it because of weird compiler quirks or the variety of compiler > versions tha

Re: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-24 Thread Harry Wentland
On 5/24/23 15:27, Hamza Mahfooz wrote: > On 5/24/23 15:22, Alex Deucher wrote: >> On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote: >>> >>> Currently, there are quite a number of issues that are quite easy for >>> the CI to catch, that slip through the cracks. Among them, there are >>> unuse

Re: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-24 Thread Alex Deucher
ooz, Hamza > > > > *Cc:* Li, Sun peng (Leo) ; Wentland, Harry > > ; Pan, Xinhui ; Siqueira, > > Rodrigo ; linux-ker...@vger.kernel.org; > > dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Daniel > > Vetter ; Deucher, Alexander > > ; Davi

Re: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-24 Thread Felix Kuehling
: [PATCH v2] drm/amd/display: enable more strict compile checks [AMD Official Use Only - General] [AMD Official Use Only - General] (+ Felix) Should we do the same for other modules under amd (amdkfd)?  I was going to enable full kernel werror in the kconfig used by my CI but this is

RE: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-24 Thread Russell, Kent
; Pan, Xinhui ; Siqueira, Rodrigo ; linux-ker...@vger.kernel.org; dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Daniel Vetter ; Deucher, Alexander ; David Airlie ; Koenig, Christian Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks [AMD Official Use

Re: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-24 Thread Hamza Mahfooz
On 5/24/23 15:22, Alex Deucher wrote: On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote: Currently, there are quite a number of issues that are quite easy for the CI to catch, that slip through the cracks. Among them, there are unused variable and indentation issues. Also, we should consider

Re: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-24 Thread Ho, Kenny
: Re: [PATCH v2] drm/amd/display: enable more strict compile checks On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote: > > Currently, there are quite a number of issues that are quite easy for > the CI to catch, that slip through the cracks. Among them, there are > unused variable and

Re: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-24 Thread Alex Deucher
On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote: > > Currently, there are quite a number of issues that are quite easy for > the CI to catch, that slip through the cracks. Among them, there are > unused variable and indentation issues. Also, we should consider all > warnings to be compile erro

[PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-24 Thread Hamza Mahfooz
Currently, there are quite a number of issues that are quite easy for the CI to catch, that slip through the cracks. Among them, there are unused variable and indentation issues. Also, we should consider all warnings to be compile errors, since the community will eventually end up complaining about