Re: [PATCH v2] drm/amdgpu: Reserve shared fence slot in amdgpu_vm_update_directories

2018-07-03 Thread Zhang, Jerry (Junwei)
On 07/03/2018 04:42 PM, Christian König wrote: Am 03.07.2018 um 10:12 schrieb Zhang, Jerry (Junwei): On 07/03/2018 02:58 PM, Christian König wrote: Am 03.07.2018 um 03:59 schrieb Zhang, Jerry (Junwei): On 07/02/2018 05:23 PM, Christian König wrote: [SNIP] The

Re: [PATCH v2] drm/amdgpu: Reserve shared fence slot in amdgpu_vm_update_directories

2018-07-03 Thread Christian König
Am 03.07.2018 um 10:12 schrieb Zhang, Jerry (Junwei): On 07/03/2018 02:58 PM, Christian König wrote: Am 03.07.2018 um 03:59 schrieb Zhang, Jerry (Junwei): On 07/02/2018 05:23 PM, Christian König wrote: [SNIP] The reservation_object_reserve_shared() function needs to be called before you make

Re: [PATCH v2] drm/amdgpu: Reserve shared fence slot in amdgpu_vm_update_directories

2018-07-03 Thread Zhang, Jerry (Junwei)
On 07/03/2018 04:28 PM, Michel Dänzer wrote: On 2018-07-03 10:12 AM, Zhang, Jerry (Junwei) wrote: BTW, reservation_object_reserve_shared() will extend the max num as 2 times if it's not enough. (default value is 4) That's an implementation detail and depends on the circumstances. The only

Re: [PATCH v2] drm/amdgpu: Reserve shared fence slot in amdgpu_vm_update_directories

2018-07-03 Thread Michel Dänzer
On 2018-07-03 10:12 AM, Zhang, Jerry (Junwei) wrote: > > BTW, reservation_object_reserve_shared() will extend the max num as 2 > times if it's not enough. > (default value is 4) That's an implementation detail and depends on the circumstances. The only guarantee is that there's space for at

Re: [PATCH v2] drm/amdgpu: Reserve shared fence slot in amdgpu_vm_update_directories

2018-07-03 Thread Zhang, Jerry (Junwei)
On 07/03/2018 02:58 PM, Christian König wrote: Am 03.07.2018 um 03:59 schrieb Zhang, Jerry (Junwei): On 07/02/2018 05:23 PM, Christian König wrote: Am 25.06.2018 um 11:07 schrieb Michel Dänzer: From: Michel Dänzer Without this, there could not be enough slots, which could trigger the BUG_ON

Re: [PATCH v2] drm/amdgpu: Reserve shared fence slot in amdgpu_vm_update_directories

2018-07-03 Thread Christian König
Am 03.07.2018 um 03:59 schrieb Zhang, Jerry (Junwei): On 07/02/2018 05:23 PM, Christian König wrote: Am 25.06.2018 um 11:07 schrieb Michel Dänzer: From: Michel Dänzer Without this, there could not be enough slots, which could trigger the BUG_ON in reservation_object_add_shared_fence. v2: *

Re: [PATCH v2] drm/amdgpu: Reserve shared fence slot in amdgpu_vm_update_directories

2018-07-02 Thread Zhang, Jerry (Junwei)
On 07/02/2018 05:23 PM, Christian König wrote: Am 25.06.2018 um 11:07 schrieb Michel Dänzer: From: Michel Dänzer Without this, there could not be enough slots, which could trigger the BUG_ON in reservation_object_add_shared_fence. v2: * Jump to the error label instead of returning directly

Re: [PATCH v2] drm/amdgpu: Reserve shared fence slot in amdgpu_vm_update_directories

2018-07-02 Thread Christian König
Am 25.06.2018 um 11:07 schrieb Michel Dänzer: From: Michel Dänzer Without this, there could not be enough slots, which could trigger the BUG_ON in reservation_object_add_shared_fence. v2: * Jump to the error label instead of returning directly (Jerry Zhang) Well good catch, but NAK that is

Re: [PATCH v2] drm/amdgpu: Reserve shared fence slot in amdgpu_vm_update_directories

2018-06-25 Thread Zhang, Jerry (Junwei)
On 06/25/2018 05:07 PM, Michel Dänzer wrote: From: Michel Dänzer Without this, there could not be enough slots, which could trigger the BUG_ON in reservation_object_add_shared_fence. v2: * Jump to the error label instead of returning directly (Jerry Zhang) Cc: sta...@vger.kernel.org

[PATCH v2] drm/amdgpu: Reserve shared fence slot in amdgpu_vm_update_directories

2018-06-25 Thread Michel Dänzer
From: Michel Dänzer Without this, there could not be enough slots, which could trigger the BUG_ON in reservation_object_add_shared_fence. v2: * Jump to the error label instead of returning directly (Jerry Zhang) Cc: sta...@vger.kernel.org Bugzilla: https://bugs.freedesktop.org/106418