Re: [PATCH v2] drm/amdgpu: add safeguards for querying GMC CG state

2022-01-28 Thread Lazar, Lijo
On 1/28/2022 2:46 PM, Lang Yu wrote: On 01/28/ , Lazar, Lijo wrote: On 1/28/2022 2:22 PM, Lang Yu wrote: On 01/28/ , Lazar, Lijo wrote: On 1/28/2022 12:24 PM, Lang Yu wrote: We observed a GPU hang when querying GMC CG state(i.e., cat amdgpu_pm_info) on cyan skillfish. Acctually, cyan

Re: [PATCH v2] drm/amdgpu: add safeguards for querying GMC CG state

2022-01-28 Thread Lang Yu
On 01/28/ , Lazar, Lijo wrote: > > > On 1/28/2022 2:22 PM, Lang Yu wrote: > > On 01/28/ , Lazar, Lijo wrote: > > > > > > > > > On 1/28/2022 12:24 PM, Lang Yu wrote: > > > > We observed a GPU hang when querying GMC CG state(i.e., > > > > cat amdgpu_pm_info) on cyan skillfish. Acctually, cyan >

Re: [PATCH v2] drm/amdgpu: add safeguards for querying GMC CG state

2022-01-28 Thread Lazar, Lijo
On 1/28/2022 2:22 PM, Lang Yu wrote: On 01/28/ , Lazar, Lijo wrote: On 1/28/2022 12:24 PM, Lang Yu wrote: We observed a GPU hang when querying GMC CG state(i.e., cat amdgpu_pm_info) on cyan skillfish. Acctually, cyan skillfish doesn't support any CG features. Only allow ASICs which

Re: [PATCH v2] drm/amdgpu: add safeguards for querying GMC CG state

2022-01-28 Thread Lang Yu
On 01/28/ , Lazar, Lijo wrote: > > > On 1/28/2022 12:24 PM, Lang Yu wrote: > > We observed a GPU hang when querying GMC CG state(i.e., > > cat amdgpu_pm_info) on cyan skillfish. Acctually, cyan > > skillfish doesn't support any CG features. > > > > Only allow ASICs which support GMC CG features

Re: [PATCH v2] drm/amdgpu: add safeguards for querying GMC CG state

2022-01-28 Thread Lazar, Lijo
On 1/28/2022 12:24 PM, Lang Yu wrote: We observed a GPU hang when querying GMC CG state(i.e., cat amdgpu_pm_info) on cyan skillfish. Acctually, cyan skillfish doesn't support any CG features. Only allow ASICs which support GMC CG features accessing related registers. As some ASICs support

[PATCH v2] drm/amdgpu: add safeguards for querying GMC CG state

2022-01-27 Thread Lang Yu
We observed a GPU hang when querying GMC CG state(i.e., cat amdgpu_pm_info) on cyan skillfish. Acctually, cyan skillfish doesn't support any CG features. Only allow ASICs which support GMC CG features accessing related registers. As some ASICs support GMC CG but cg_flags are not set. Use GC IP