Re: [PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-27 Thread Tvrtko Ursulin
On 26/09/2024 09:15, Philipp Stanner wrote: On Mon, 2024-09-23 at 15:35 +0100, Tvrtko Ursulin wrote: Ping Christian and Philipp - reasonably happy with v2? I think it's the only unreviewed patch from the series. Howdy, sry for the delay, I had been traveling. I have a few nits below regar

Re: [PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-26 Thread Christian König
Am 26.09.24 um 10:18 schrieb Philipp Stanner: On Tue, 2024-09-24 at 14:02 +0200, Christian König wrote: Am 24.09.24 um 11:58 schrieb Tvrtko Ursulin: On 24/09/2024 10:45, Tvrtko Ursulin wrote: On 24/09/2024 09:20, Christian König wrote: Am 16.09.24 um 19:30 schrieb Tvrtko Ursulin: From: Tvrtk

Re: [PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-26 Thread Philipp Stanner
On Tue, 2024-09-24 at 14:02 +0200, Christian König wrote: > Am 24.09.24 um 11:58 schrieb Tvrtko Ursulin: > > > > On 24/09/2024 10:45, Tvrtko Ursulin wrote: > > > > > > On 24/09/2024 09:20, Christian König wrote: > > > > Am 16.09.24 um 19:30 schrieb Tvrtko Ursulin: > > > > > From: Tvrtko Ursulin

Re: [PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-26 Thread Philipp Stanner
On Mon, 2024-09-23 at 15:35 +0100, Tvrtko Ursulin wrote: > > Ping Christian and Philipp - reasonably happy with v2? I think it's > the > only unreviewed patch from the series. Howdy, sry for the delay, I had been traveling. I have a few nits below regarding the commit message. Besides, I'm OK

Re: [PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-24 Thread Tvrtko Ursulin
On 24/09/2024 10:45, Tvrtko Ursulin wrote: On 24/09/2024 09:20, Christian König wrote: Am 16.09.24 um 19:30 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny

Re: [PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-24 Thread Tvrtko Ursulin
On 24/09/2024 09:20, Christian König wrote: Am 16.09.24 um 19:30 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit larger refactoring we can do the same opt

Re: [PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-24 Thread Christian König
Am 24.09.24 um 11:58 schrieb Tvrtko Ursulin: On 24/09/2024 10:45, Tvrtko Ursulin wrote: On 24/09/2024 09:20, Christian König wrote: Am 16.09.24 um 19:30 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise

Re: [PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-24 Thread Tvrtko Ursulin
Ping Christian and Philipp - reasonably happy with v2? I think it's the only unreviewed patch from the series. Regards, Tvrtko On 16/09/2024 18:30, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_s

Re: [PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-24 Thread Christian König
Am 16.09.24 um 19:30 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit larger refactoring we can do the same optimisation on the rq->lock. (Currently both drm_

[PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-16 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit larger refactoring we can do the same optimisation on the rq->lock. (Currently both drm_sched_rq_add_entity() and drm_sched_rq_update_f