Re: [PATCH v2] drm: Check actual format for legacy pageflip.

2021-01-12 Thread Daniel Vetter
On Mon, Jan 11, 2021 at 04:28:31PM -0500, Alex Deucher wrote: > On Mon, Jan 11, 2021 at 11:39 AM Bas Nieuwenhuizen > wrote: > > > > On Mon, Jan 11, 2021 at 4:02 PM Alex Deucher wrote: > > > > > > On Sat, Jan 9, 2021 at 9:11 PM Bas Nieuwenhuizen > > > wrote: > > > > > > > > With modifiers one can

Re: [PATCH v2] drm: Check actual format for legacy pageflip.

2021-01-11 Thread Alex Deucher
On Mon, Jan 11, 2021 at 11:39 AM Bas Nieuwenhuizen wrote: > > On Mon, Jan 11, 2021 at 4:02 PM Alex Deucher wrote: > > > > On Sat, Jan 9, 2021 at 9:11 PM Bas Nieuwenhuizen > > wrote: > > > > > > With modifiers one can actually have different format_info structs > > > for the same format, which no

Re: [PATCH v2] drm: Check actual format for legacy pageflip.

2021-01-11 Thread Bas Nieuwenhuizen
On Mon, Jan 11, 2021 at 4:02 PM Alex Deucher wrote: > > On Sat, Jan 9, 2021 at 9:11 PM Bas Nieuwenhuizen > wrote: > > > > With modifiers one can actually have different format_info structs > > for the same format, which now matters for AMDGPU since we convert > > implicit modifiers to explicit mo

Re: [PATCH v2] drm: Check actual format for legacy pageflip.

2021-01-11 Thread Alex Deucher
On Sat, Jan 9, 2021 at 9:11 PM Bas Nieuwenhuizen wrote: > > With modifiers one can actually have different format_info structs > for the same format, which now matters for AMDGPU since we convert > implicit modifiers to explicit modifiers with multiple planes. > > I checked other drivers and it do

[PATCH v2] drm: Check actual format for legacy pageflip.

2021-01-09 Thread Bas Nieuwenhuizen
With modifiers one can actually have different format_info structs for the same format, which now matters for AMDGPU since we convert implicit modifiers to explicit modifiers with multiple planes. I checked other drivers and it doesn't look like they end up triggering this case so I think this is