Re: [PATCH v2 3/8] drm/ttm: Add unampping of the entire device address space

2020-06-23 Thread Christian König
Am 23.06.20 um 12:25 schrieb Daniel Vetter: On Tue, Jun 23, 2020 at 01:00:02AM -0400, Andrey Grodzovsky wrote: On 6/22/20 5:45 AM, Daniel Vetter wrote: On Sun, Jun 21, 2020 at 02:03:03AM -0400, Andrey Grodzovsky wrote: Helper function to be used to invalidate all BOs CPU mappings once device

Re: [PATCH v2 3/8] drm/ttm: Add unampping of the entire device address space

2020-06-23 Thread Daniel Vetter
On Tue, Jun 23, 2020 at 01:00:02AM -0400, Andrey Grodzovsky wrote: > > On 6/22/20 5:45 AM, Daniel Vetter wrote: > > On Sun, Jun 21, 2020 at 02:03:03AM -0400, Andrey Grodzovsky wrote: > > > Helper function to be used to invalidate all BOs CPU mappings > > > once device is removed. > > > > > >

Re: [PATCH v2 3/8] drm/ttm: Add unampping of the entire device address space

2020-06-22 Thread Andrey Grodzovsky
On 6/22/20 5:45 AM, Daniel Vetter wrote: On Sun, Jun 21, 2020 at 02:03:03AM -0400, Andrey Grodzovsky wrote: Helper function to be used to invalidate all BOs CPU mappings once device is removed. Signed-off-by: Andrey Grodzovsky This seems to be missing the code to invalidate all the dma-buf

Re: [PATCH v2 3/8] drm/ttm: Add unampping of the entire device address space

2020-06-22 Thread Alex Deucher
On Sun, Jun 21, 2020 at 2:05 AM Andrey Grodzovsky wrote: > > Helper function to be used to invalidate all BOs CPU mappings > once device is removed. > > Signed-off-by: Andrey Grodzovsky Typo in the subject: unampping -> unmapping Alex > --- > drivers/gpu/drm/ttm/ttm_bo.c| 8 ++-- >

Re: [PATCH v2 3/8] drm/ttm: Add unampping of the entire device address space

2020-06-22 Thread Christian König
Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky: Helper function to be used to invalidate all BOs CPU mappings once device is removed. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c| 8 ++-- include/drm/ttm/ttm_bo_driver.h | 7

Re: [PATCH v2 3/8] drm/ttm: Add unampping of the entire device address space

2020-06-22 Thread Daniel Vetter
On Sun, Jun 21, 2020 at 02:03:03AM -0400, Andrey Grodzovsky wrote: > Helper function to be used to invalidate all BOs CPU mappings > once device is removed. > > Signed-off-by: Andrey Grodzovsky This seems to be missing the code to invalidate all the dma-buf mmaps? Probably needs more testcases

[PATCH v2 3/8] drm/ttm: Add unampping of the entire device address space

2020-06-21 Thread Andrey Grodzovsky
Helper function to be used to invalidate all BOs CPU mappings once device is removed. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/ttm/ttm_bo.c| 8 ++-- include/drm/ttm/ttm_bo_driver.h | 7 +++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git