Re: [PATCH v3 1/8] drm/amdgpu: Implement DPC recovery

2020-08-31 Thread Luben Tuikov
On 2020-08-31 11:50 a.m., Andrey Grodzovsky wrote: > Add DPC handlers with basic recovery functionality. > > v2: remove pci_save_state to avoid breaking suspend/resume > v3: Fix style comments > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 9 ++ > dr

Re: [PATCH v3 1/8] drm/amdgpu: Implement DPC recovery

2020-08-31 Thread Luben Tuikov
On 2020-08-31 11:50 a.m., Andrey Grodzovsky wrote: > Add DPC handlers with basic recovery functionality. > When this goes into the kernel log, it would be quite unclear what "DPC" stands for, as it is used undefined in this patch and this patchset. I'd write, Add PCI Downstream Port Con

[PATCH v3 1/8] drm/amdgpu: Implement DPC recovery

2020-08-31 Thread Andrey Grodzovsky
Add DPC handlers with basic recovery functionality. v2: remove pci_save_state to avoid breaking suspend/resume v3: Fix style comments Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 9 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 162 ++