Re: [PATCH v3 2/2] radeon: use memcpy_to/fromio for UVD fw upload

2021-06-04 Thread Christian König
Am 04.06.21 um 10:28 schrieb Chen Li: On Fri, 04 Jun 2021 16:08:26 +0800, Christian König wrote: Am 04.06.21 um 09:53 schrieb Chen Li: I met a gpu addr bug recently and the kernel log tells me the pc is memcpy/memset and link register is radeon_uvd_resume. As we know, in some architectures

Re: [PATCH v3 2/2] radeon: use memcpy_to/fromio for UVD fw upload

2021-06-04 Thread Chen Li
On Fri, 04 Jun 2021 16:31:28 +0800, Christian König wrote: > > > > Am 04.06.21 um 10:28 schrieb Chen Li: > > On Fri, 04 Jun 2021 16:08:26 +0800, > > Christian König wrote: > >> > >> > >> Am 04.06.21 um 09:53 schrieb Chen Li: > >>> I met a gpu addr bug recently and the kernel log > >>> tells me

Re: [PATCH v3 2/2] radeon: use memcpy_to/fromio for UVD fw upload

2021-06-04 Thread Chen Li
On Fri, 04 Jun 2021 16:08:26 +0800, Christian König wrote: > > > > Am 04.06.21 um 09:53 schrieb Chen Li: > > I met a gpu addr bug recently and the kernel log > > tells me the pc is memcpy/memset and link register is > > radeon_uvd_resume. > > > > As we know, in some architectures, optimized mem

[PATCH v3 2/2] radeon: use memcpy_to/fromio for UVD fw upload

2021-06-04 Thread Chen Li
I met a gpu addr bug recently and the kernel log tells me the pc is memcpy/memset and link register is radeon_uvd_resume. As we know, in some architectures, optimized memcpy/memset may not work well on device memory. Trival memcpy_toio/memset_io can fix this problem. BTW, amdgpu has already don

Re: [PATCH v3 2/2] radeon: use memcpy_to/fromio for UVD fw upload

2021-06-04 Thread Christian König
Am 04.06.21 um 09:53 schrieb Chen Li: I met a gpu addr bug recently and the kernel log tells me the pc is memcpy/memset and link register is radeon_uvd_resume. As we know, in some architectures, optimized memcpy/memset may not work well on device memory. Trival memcpy_toio/memset_io can fix th