RE: [Patch v1 5/5] drm/amdkfd: refactor runtime pm for baco

2020-01-30 Thread Zeng, Oak
Subject: Re: [Patch v1 5/5] drm/amdkfd: refactor runtime pm for baco On 2020-01-30 17:11, Alex Deucher wrote: > On Thu, Jan 30, 2020 at 4:55 PM Felix Kuehling wrote: >> On 2020-01-30 14:01, Bhardwaj, Rajneesh wrote: >>> Hello Felix, >>> >>> Thanks for your

Re: [Patch v1 5/5] drm/amdkfd: refactor runtime pm for baco

2020-01-30 Thread Felix Kuehling
On 2020-01-30 17:11, Alex Deucher wrote: On Thu, Jan 30, 2020 at 4:55 PM Felix Kuehling wrote: On 2020-01-30 14:01, Bhardwaj, Rajneesh wrote: Hello Felix, Thanks for your time to review and for your feedback. On 1/29/2020 5:52 PM, Felix Kuehling wrote: HI Rajneesh, See comments inline ...

Re: [Patch v1 5/5] drm/amdkfd: refactor runtime pm for baco

2020-01-30 Thread Alex Deucher
On Thu, Jan 30, 2020 at 4:55 PM Felix Kuehling wrote: > > On 2020-01-30 14:01, Bhardwaj, Rajneesh wrote: > > Hello Felix, > > > > Thanks for your time to review and for your feedback. > > > > On 1/29/2020 5:52 PM, Felix Kuehling wrote: > >> HI Rajneesh, > >> > >> See comments inline ... > >> > >>

Re: [Patch v1 5/5] drm/amdkfd: refactor runtime pm for baco

2020-01-30 Thread Felix Kuehling
On 2020-01-30 14:01, Bhardwaj, Rajneesh wrote: Hello Felix, Thanks for your time to review and for your feedback. On 1/29/2020 5:52 PM, Felix Kuehling wrote: HI Rajneesh, See comments inline ... And a general question: Why do you need to set the autosuspend_delay in so many places? Amdgpu o

Re: [Patch v1 5/5] drm/amdkfd: refactor runtime pm for baco

2020-01-30 Thread Bhardwaj, Rajneesh
, Felix ; Bhardwaj, Rajneesh Subject: [Patch v1 5/5] drm/amdkfd: refactor runtime pm for baco So far the kfd driver implemented same routines for runtime and system wide suspend and resume (s2idle or mem). During system wide suspend the kfd aquires an atomic lock that prevents any more user

Re: [Patch v1 5/5] drm/amdkfd: refactor runtime pm for baco

2020-01-30 Thread Bhardwaj, Rajneesh
Hello Felix, Thanks for your time to review and for your feedback. On 1/29/2020 5:52 PM, Felix Kuehling wrote: HI Rajneesh, See comments inline ... And a general question: Why do you need to set the autosuspend_delay in so many places? Amdgpu only has a single call to this function during i

Re: [Patch v1 5/5] drm/amdkfd: refactor runtime pm for baco

2020-01-29 Thread Felix Kuehling
HI Rajneesh, See comments inline ... And a general question: Why do you need to set the autosuspend_delay in so many places? Amdgpu only has a single call to this function during initialization. On 2020-01-27 20:29, Rajneesh Bhardwaj wrote: So far the kfd driver implemented same routines fo

RE: [Patch v1 5/5] drm/amdkfd: refactor runtime pm for baco

2020-01-28 Thread Zeng, Oak
v1 5/5] drm/amdkfd: refactor runtime pm for baco So far the kfd driver implemented same routines for runtime and system wide suspend and resume (s2idle or mem). During system wide suspend the kfd aquires an atomic lock that prevents any more user processes to create queues and interact with kfd

[Patch v1 5/5] drm/amdkfd: refactor runtime pm for baco

2020-01-27 Thread Rajneesh Bhardwaj
So far the kfd driver implemented same routines for runtime and system wide suspend and resume (s2idle or mem). During system wide suspend the kfd aquires an atomic lock that prevents any more user processes to create queues and interact with kfd driver and amd gpu. This mechanism created problem w