Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-03-21 Thread James Turner
>>> Right, interference from host drivers and pre-boot environments is >>> always a concern with GPU assignment in particular. AMD GPUs have a >>> long history of poor behavior relative to things like PCI secondary >>> bus resets which we use to try to get devices to clean, reusable >>> states for

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-03-18 Thread Alex Williamson
On Fri, 18 Mar 2022 11:06:00 -0400 Alex Deucher wrote: > On Fri, Mar 18, 2022 at 10:46 AM Alex Williamson > wrote: > > > > On Fri, 18 Mar 2022 08:01:31 +0100 > > Thorsten Leemhuis wrote: > > > > > On 18.03.22 06:43, Paul Menzel wrote: > > > > > > > > Am 17.03.22 um 13:54 schrieb Thorsten Le

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-03-18 Thread Alex Deucher
On Fri, Mar 18, 2022 at 10:46 AM Alex Williamson wrote: > > On Fri, 18 Mar 2022 08:01:31 +0100 > Thorsten Leemhuis wrote: > > > On 18.03.22 06:43, Paul Menzel wrote: > > > > > > Am 17.03.22 um 13:54 schrieb Thorsten Leemhuis: > > >> On 13.03.22 19:33, James Turner wrote: > > >>> > > My under

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-03-18 Thread Alex Williamson
On Fri, 18 Mar 2022 08:01:31 +0100 Thorsten Leemhuis wrote: > On 18.03.22 06:43, Paul Menzel wrote: > > > > Am 17.03.22 um 13:54 schrieb Thorsten Leemhuis: > >> On 13.03.22 19:33, James Turner wrote: > >>> > My understanding at this point is that the root problem is probably > not

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-03-18 Thread Thorsten Leemhuis
On 18.03.22 06:43, Paul Menzel wrote: > > Am 17.03.22 um 13:54 schrieb Thorsten Leemhuis: >> On 13.03.22 19:33, James Turner wrote: >>> My understanding at this point is that the root problem is probably not in the Linux kernel but rather something else (e.g. the machine firmware or

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-03-17 Thread Paul Menzel
Dear Thorsten, dear James, Am 17.03.22 um 13:54 schrieb Thorsten Leemhuis: On 13.03.22 19:33, James Turner wrote: My understanding at this point is that the root problem is probably not in the Linux kernel but rather something else (e.g. the machine firmware or AMD Windows driver) and that t

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-03-17 Thread Thorsten Leemhuis
On 13.03.22 19:33, James Turner wrote: > >> My understanding at this point is that the root problem is probably >> not in the Linux kernel but rather something else (e.g. the machine >> firmware or AMD Windows driver) and that the change in f9b7f3703ff9 >> ("drm/amdgpu/acpi: make ATPX/ATCS structur

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-03-14 Thread James Turner
Hi all, I've confirmed that changing the `amdgpu_atif_pci_probe_handle` function to do nothing does make the GPU work properly in the VM. I started with f9b7f3703ff9 ("drm/amdgpu/acpi: make ATPX/ATCS structures global (v2)") and changed the function implementation to: static bool amdgpu_atif_pci_

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-03-07 Thread Thorsten Leemhuis
Hi, this is your Linux kernel regression tracker again. Top-posting once more, to make this easily accessible to everyone. What's the status of this? It looks stuck, or did the discussion continue somewhere else? James, it sounded like you wanted to test something, did you give it a try? Or is the

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-03-07 Thread James Turner
Hi Thorsten, My understanding at this point is that the root problem is probably not in the Linux kernel but rather something else (e.g. the machine firmware or AMD Windows driver) and that the change in f9b7f3703ff9 ("drm/amdgpu/acpi: make ATPX/ATCS structures global (v2)") simply exposed the und

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-02-16 Thread Alex Deucher
On Tue, Feb 15, 2022 at 9:35 PM James D. Turner wrote: > > Hi Alex, > > > I guess just querying the ATIF method does something that negatively > > influences the windows driver in the guest. Perhaps the platform > > thinks the driver has been loaded since the method has been called so > > it enabl

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-02-16 Thread James D . Turner
Hi Alex, > I guess just querying the ATIF method does something that negatively > influences the windows driver in the guest. Perhaps the platform > thinks the driver has been loaded since the method has been called so > it enables certain behaviors that require ATIF interaction that never > happe

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-02-15 Thread Thorsten Leemhuis
Top-posting for once, to make this easy accessible to everyone. Nothing happened here for two weeks now afaics. Was the discussion moved elsewhere or did it fall through the cracks? Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tr

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-02-15 Thread Alex Deucher
On Tue, Feb 15, 2022 at 9:56 AM Thorsten Leemhuis wrote: > > Top-posting for once, to make this easy accessible to everyone. > > Nothing happened here for two weeks now afaics. Was the discussion moved > elsewhere or did it fall through the cracks? > > Ciao, Thorsten (wearing his 'the Linux kernel

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-01-25 Thread Lazar, Lijo
On 1/25/2022 5:28 AM, James Turner wrote: Hi Lijo, Not able to relate to how it affects gfx/mem DPM alone. Unless Alex has other ideas, would you be able to enable drm debug messages and share the log? Sure, I'm happy to provide drm debug messages. Enabling everything (0x1ff) generates *a

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-01-25 Thread James Turner
Hi Lijo, > Not able to relate to how it affects gfx/mem DPM alone. Unless Alex > has other ideas, would you be able to enable drm debug messages and > share the log? Sure, I'm happy to provide drm debug messages. Enabling everything (0x1ff) generates *a lot* of log messages, though. Is there a sm

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-01-24 Thread Alex Williamson
On Mon, 24 Jan 2022 12:04:18 -0500 Alex Deucher wrote: > On Sat, Jan 22, 2022 at 4:38 PM James Turner > wrote: > > > > Hi Lijo, > > > > > Could you provide the pp_dpm_* values in sysfs with and without the > > > patch? Also, could you try forcing PCIE to gen3 (through pp_dpm_pcie) > > > if it'

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-01-24 Thread Alex Deucher
On Sat, Jan 22, 2022 at 4:38 PM James Turner wrote: > > Hi Lijo, > > > Could you provide the pp_dpm_* values in sysfs with and without the > > patch? Also, could you try forcing PCIE to gen3 (through pp_dpm_pcie) > > if it's not in gen3 when the issue happens? > > AFAICT, I can't access those valu

RE: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-01-24 Thread Lazar, Lijo
regressi...@lists.linux.dev; k...@vger.kernel.org; Greg KH ; Pan, Xinhui ; LKML ; amd-gfx@lists.freedesktop.org; Alex Williamson ; Koenig, Christian Subject: Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM Hi Lijo, > Could you provide the pp_dpm_* values in sys

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-01-24 Thread James Turner
Hi Lijo, > Could you provide the pp_dpm_* values in sysfs with and without the > patch? Also, could you try forcing PCIE to gen3 (through pp_dpm_pcie) > if it's not in gen3 when the issue happens? AFAICT, I can't access those values while the AMD GPU PCI devices are bound to `vfio-pci`. However,

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-01-22 Thread James Turner
> Are you ever loading the amdgpu driver in your tests? Yes, although I'm binding the `vfio-pci` driver to the AMD GPU's PCI devices via the kernel command line. (See my initial email.) My understanding is that `vfio-pci` is supposed to keep other drivers, such as `amdgpu`, from interacting with t

RE: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-01-21 Thread Lazar, Lijo
d-gfx@lists.freedesktop.org; Alex Williamson ; Koenig, Christian Subject: Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM > Are you ever loading the amdgpu driver in your tests? Yes, although I'm binding the `vfio-pci` driver to the AMD GPU's PCI devic

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-01-21 Thread Alex Deucher
On Fri, Jan 21, 2022 at 3:35 AM Thorsten Leemhuis wrote: > > Hi, this is your Linux kernel regression tracker speaking. > > On 21.01.22 03:13, James Turner wrote: > > > > I finished the bisection (log below). The issue was introduced in > > f9b7f3703ff9 ("drm/amdgpu/acpi: make ATPX/ATCS structures

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-01-21 Thread Thorsten Leemhuis
Hi, this is your Linux kernel regression tracker speaking. On 21.01.22 03:13, James Turner wrote: > > I finished the bisection (log below). The issue was introduced in > f9b7f3703ff9 ("drm/amdgpu/acpi: make ATPX/ATCS structures global (v2)"). FWIW, that was: > drm/amdgpu/acpi: make ATPX/ATCS st