Re: [RFC 3/4] drm/amdgpu: Add and use amdgpu_ring_write_addr() helper

2024-10-08 Thread Alex Deucher
On Tue, Oct 8, 2024 at 11:18 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > I've noticed there is really a lot of places which write addresses into > the ring as two writes of lower_32_bits() followed by upper_32_bits(). > > Is it worth adding a helper to do those in one go? > > It shrinks

[RFC 3/4] drm/amdgpu: Add and use amdgpu_ring_write_addr() helper

2024-10-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I've noticed there is really a lot of places which write addresses into the ring as two writes of lower_32_bits() followed by upper_32_bits(). Is it worth adding a helper to do those in one go? It shrinks the source and binary a bit but is the readability better, or worse?