Re: [RFC PATCH 2/9] apple-gmux: consolidate version reading

2023-02-10 Thread Orlando Chamberlain
On Fri, 10 Feb 2023 20:41:19 +0100 Hans de Goede wrote: > Hi, > > On 2/10/23 05:48, Orlando Chamberlain wrote: > > Read gmux version in one go as 32 bits on both indexed and classic > > gmux's. > > > > Classic gmux's used to read the version as > > > > major = inb(base + 0x4); > > minor =

Re: [RFC PATCH 2/9] apple-gmux: consolidate version reading

2023-02-10 Thread Hans de Goede
Hi, On 2/10/23 05:48, Orlando Chamberlain wrote: > Read gmux version in one go as 32 bits on both indexed and classic > gmux's. > > Classic gmux's used to read the version as > > major = inb(base + 0x4); > minor = inb(base + 0x5); > release = inb(base + 0x6); > > but this can instead be done

[RFC PATCH 2/9] apple-gmux: consolidate version reading

2023-02-10 Thread Orlando Chamberlain
Read gmux version in one go as 32 bits on both indexed and classic gmux's. Classic gmux's used to read the version as major = inb(base + 0x4); minor = inb(base + 0x5); release = inb(base + 0x6); but this can instead be done the same way as indexed gmux's with gmux_read32(), so the same version