Re: 回复: 回复: 回复: [PATCH] drm/ttm: Put BO in its memory manager's lru list

2021-11-09 Thread Christian König
In general the correct idea, but the wrong place to check that. Calling amdgpu_ttm_bo_eviction_valuable() is only optional, but that check must be mandatory for correct operation. This needs to be inside ttm_bo_evict_swapout_allowable(). Christian. Am 09.11.21 um 14:41 schrieb Pan, Xinhui:

回复: 回复: 回复: [PATCH] drm/ttm: Put BO in its memory manager's lru list

2021-11-09 Thread Pan, Xinhui
[AMD Official Use Only] yes, a double check is needed. how about change below. As long as we detect such mismatch, it indicates another eviction is on going. return false here is reasonable. @@ -1335,6 +1336,8 @@ static bool amdgpu_ttm_bo_eviction_valuable(struct ttm_buffer_object *bo,