-----邮件原件-----
发件人: Thomas Zimmermann [mailto:tzimmerm...@suse.de] 
发送时间: 2021年6月22日 22:10
收件人: dan...@ffwll.ch; airl...@linux.ie; alexander.deuc...@amd.com; 
christian.koe...@amd.com; xinhui....@amd.com; james.qian.w...@arm.com; 
liviu.du...@arm.com; mihail.atanas...@arm.com; brian.star...@arm.com; 
maarten.lankho...@linux.intel.com; mrip...@kernel.org; inki....@samsung.com; 
jy0922.s...@samsung.com; sw0312....@samsung.com; kyungmin.p...@samsung.com; 
krzysztof.kozlow...@canonical.com; xinliang....@linaro.org; tiantao (H) 
<tiant...@hisilicon.com>; john.stu...@linaro.org; kongxinwei (A) 
<kong.kongxin...@hisilicon.com>; Chenfeng (puck) <puck.c...@hisilicon.com>; 
laurentiu.pa...@oss.nxp.com; l.st...@pengutronix.de; p.za...@pengutronix.de; 
shawn...@kernel.org; s.ha...@pengutronix.de; ker...@pengutronix.de; 
feste...@gmail.com; linux-...@nxp.com; chunkuang...@kernel.org; 
matthias....@gmail.com; bske...@redhat.com; to...@kernel.org; 
h...@rock-chips.com; he...@sntech.de; benjamin.gaign...@linaro.org; 
yannick.fer...@foss.st.com; philippe.co...@foss.st.com; 
mcoquelin.st...@gmail.com; alexandre.tor...@foss.st.com; w...@csie.org; 
jernej.skra...@gmail.com; thierry.red...@gmail.com; jonath...@nvidia.com; 
jyri.sa...@iki.fi; e...@anholt.net; linux-graphics-maintai...@vmware.com; 
za...@vmware.com; hyun.k...@xilinx.com; laurent.pinch...@ideasonboard.com; 
michal.si...@xilinx.com
抄送: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; 
linux-arm-ker...@lists.infradead.org; linux-samsung-...@vger.kernel.org; 
linux-media...@lists.infradead.org; nouv...@lists.freedesktop.org; 
linux-rockc...@lists.infradead.org; linux-st...@st-md-mailman.stormreply.com; 
linux-su...@lists.linux.dev; linux-te...@vger.kernel.org; Thomas Zimmermann 
<tzimmerm...@suse.de>
主题: [PATCH v2 02/22] drm/hibmc: Call drm_irq_uninstall() unconditionally

Remove the check around drm_irq_uninstall(). The same test is done by the 
function internally. The tested state in irq_enabled is considered obsolete and 
should not be used by KMS drivers.

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Acked-by: Tian Tao <tiant...@hisilicon.com>

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c 
b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index f4bc5386574a..f8ef711bbe5d 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -253,8 +253,7 @@ static int hibmc_unload(struct drm_device *dev)  {
        drm_atomic_helper_shutdown(dev);
 
-       if (dev->irq_enabled)
-               drm_irq_uninstall(dev);
+       drm_irq_uninstall(dev);
 
        pci_disable_msi(to_pci_dev(dev->dev));
 
--
2.32.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to