RE: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

Thanks. Best Wishes, Emily Deng > -Original Message- > From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] > Sent: Wednesday, May 23, 2018 3:33 PM > To: Deng, Emily <emily.d...@amd.com>; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu:

Re: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

Sorry missed that one. Patch is Reviewed-by: Christian König . Nice work, Christian. Am 23.05.2018 um 07:25 schrieb Deng, Emily: Ping .. -Original Message- From: Emily Deng [mailto:emily.d...@amd.com] Sent: Monday, May 21, 2018 4:09 PM To:

RE: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

Ping .. > -Original Message- > From: Emily Deng [mailto:emily.d...@amd.com] > Sent: Monday, May 21, 2018 4:09 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deng, Emily > Subject: [PATCH] drm/amdgpu: add rcu_barrier after entity fini > > To free the fence from the

RE: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

Hi Christian, Thanks for your advice, will send a modify patch later. Best Wishes, Emily Deng From: Koenig, Christian Sent: Friday, May 18, 2018 6:36 PM To: Deng, Emily <emily.d...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: add rcu_barrier after entity fi

Re: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

gt;rcu, amdgpu_fence_free) ->     kmem_cache_free(amdgpu_fence_slab, fence); > -Original Message- > From: Koenig, Christian > Sent: Friday, May 18, 2018 5:46 PM > To: Deng, Emily <emily.d...@amd.com>; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: add rcu_bar

RE: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

> To: Deng, Emily <emily.d...@amd.com>; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: add rcu_barrier after entity fini > > Ok, I'm lost where do we use call_rcu() twice? Cause that sounds incorrect in > the first place. > > Christian. > > Am 18.05.2018

Re: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

Of Deng, Emily Sent: Friday, May 18, 2018 11:20 AM To: Koenig, Christian <christian.koe...@amd.com>; amd- g...@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: add rcu_barrier after entity fini Hi Christian, Yes, it has already one rcu_barrier, but it has called twice call_rcu, so t

RE: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

esktop.org > Subject: RE: [PATCH] drm/amdgpu: add rcu_barrier after entity fini > > Hi Christian, > Yes, it has already one rcu_barrier, but it has called twice call_rcu, > so the > one rcu_barrier just could barrier one call_rcu some time. > After I added another

RE: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

; From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] > Sent: Thursday, May 17, 2018 7:08 PM > To: Deng, Emily <emily.d...@amd.com>; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: add rcu_barrier after entity fini > > Am 17.05.2018 um 12:03 schrieb Emily

Re: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

Am 17.05.2018 um 12:03 schrieb Emily Deng: To free the fence from the amdgpu_fence_slab, need twice call_rcu, to avoid the amdgpu_fence_slab_fini call kmem_cache_destroy(amdgpu_fence_slab) before kmem_cache_free(amdgpu_fence_slab, fence), add rcu_barrier after drm_sched_entity_fini. The

RE: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

2018 4:39 PM > To: Deng, Emily <emily.d...@amd.com>; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: add rcu_barrier after entity fini > > Am 17.05.2018 um 05:05 schrieb Emily Deng: > > To free the fence from the amdgpu_fence_slab, need twice call_rcu, to >

Re: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

Am 17.05.2018 um 05:05 schrieb Emily Deng: To free the fence from the amdgpu_fence_slab, need twice call_rcu, to avoid the amdgpu_fence_slab_fini call kmem_cache_destroy(amdgpu_fence_slab) before kmem_cache_free(amdgpu_fence_slab, fence), add rcu_barrier after drm_sched_entity_fini. The

Re: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

On 2018-05-17 05:05 AM, Emily Deng wrote: > To free the fence from the amdgpu_fence_slab, need twice call_rcu, to avoid > the amdgpu_fence_slab_fini call kmem_cache_destroy(amdgpu_fence_slab) before > kmem_cache_free(amdgpu_fence_slab, fence), add rcu_barrier after > drm_sched_entity_fini. > >

RE: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

Looks good, Acked-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Emily Deng Sent: Thursday, May 17, 2018 11:05 AM To: amd-gfx@lists.freedesktop.org Cc: Deng, Emily Subject: [PATCH]