rted defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> Your patch has style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKP
op.org; Zhang, Bokun
; Deucher, Alexander
Cc: Xiao, Jack ; Wang, Yang(Kevin) ;
Xu, Feifei ; Chen, Horace ; Tuikov,
Luben ; Sohail, Rashid ; Quan,
Evan ; Liu, Monk ; Zhang, Hawking
Subject: RE: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
[AMD Official Use
.org; Zhang, Bokun
Cc: Quan, Evan ; Chen, Horace
; Tuikov, Luben ; Deucher,
Alexander ; Xiao, Jack ;
Zhang, Hawking ; Liu, Monk ;
Xu, Feifei ; Wang, Yang(Kevin)
; Sohail, Rashid
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Yeah, I mean the code l
Monk ;
> Xu, Feifei ; Wang, Yang(Kevin)
> ; Sohail, Rashid
> Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
> vram_usagebyfirmware_v2_2
>
> Yeah, I mean the code looks correct.
>
> It's just that style problems are usually pointed out by automated chec
; Zhang, Bokun
Cc: Quan, Evan ; Chen, Horace ; Tuikov, Luben ; Deucher,
Alexander ; Xiao, Jack ; Zhang, Hawking ; Liu, Monk
; Xu, Feifei ; Wang, Yang(Kevin) ; Sohail, Rashid
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Yeah, I mean the code
; Chen, Horace ; Tuikov,
Luben ; Deucher, Alexander ;
Xiao, Jack ; Zhang, Hawking ; Liu,
Monk ; Xu, Feifei ; Wang, Yang(Kevin)
; Sohail, Rashid
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Yeah, I mean the code looks correct.
It's just
fei ; Wang, Yang(Kevin) ; Sohail, Rashid
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Hi,
Applying this patch to amd-staging-drm-next, with checkpatch.pl enabled,
generates the following output. Perhaps those issues should be address and
fix
> Thanks,
> Christian.
>
> Am 08.11.22 um 14:49 schrieb Chang, HaiJun:
>> [AMD Official Use Only - General]
>>
>> + Bokun to help addressing the coding style problem in MKM side.
>>
>> -Original Message-
>> From: Koenig, Christian
>> S
hang, HaiJun:
>> [AMD Official Use Only - General]
>>
>> + Bokun to help addressing the coding style problem in MKM side.
>>
>> -Original Message-
>> From: Koenig, Christian
>> Sent: Tuesday, November 8, 2022 8:53 PM
>> To: Liu01, Tong (Esther)
ander ; Xiao, Jack ; Zhang, Hawking ; Liu, Monk
; Xu, Feifei ; Wang, Yang(Kevin) ; Chang, HaiJun
; Sohail, Rashid
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Hi Esther
well there are a couple of things which you need to address before getting
; Deucher, Alexander ;
Xiao, Jack ; Zhang, Hawking ; Liu,
Monk ; Xu, Feifei ; Wang, Yang(Kevin)
; Chang, HaiJun ; Sohail, Rashid
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Hi Esther
well there are a couple of things which you need to address
Hi Esther
well there are a couple of things which you need to address before
getting this merged.
First of all the patch you send out uses dos line endings instead of the
unix line endings. Not sure how you manage to do that, but please use
"git send-email" instead to avoid that.
Then your
[AMD Official Use Only - General]
Hi @Koenig, Christian,
Refined as your comment. By the way:
if ((start_addr & ATOM_VRAM_OPERATION_FLAGS_MASK) ==
+ (uint32_t)(ATOM_VRAM_BLOCK_SRIOV_MSG_SHARE_RESERVATION <<
+ ATOM_VRAM_OPERATION_FLAGS_SHIFT))
This part is the old code
Am 08.11.22 um 03:46 schrieb Tong Liu01:
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve TMR
region firstly to make sure TMR can be allocated at 2MB
Signed-off-by: Tong Liu01
---
.../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 106 ++
drivers/gpu/drm/amd
[AMD Official Use Only - General]
Hi @Koenig, Christian,
Removed the code format style warning base on the checkpatch.pl script. Please
help me review the new patch below, thanks!
Kind regards,
Esther
-Original Message-
From: Tong Liu01
Sent: 2022年11月8日星期二 上午10:47
To: amd-gfx@lists.f
Am 07.11.22 um 04:32 schrieb Tong Liu01:
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve TMR region
firstly to make sure TMR can be allocated at 2MB
At few coding style things below, but looks good to me from the
technically side.
Please use the checkpatch.pl script, it
[AMD Official Use Only - General]
Hi @Koenig, Christian & @Wang, Yang(Kevin),
Refined patch based on your comments, please help review new patch below,
thanks!
Kind regards,
Esther
-Original Message-
From: Tong Liu01
Sent: 2022年11月7日星期一 上午11:33
To: amd-gfx@lists.freedesktop.org
Cc: A
[AMD Official Use Only - General]
Hi @Koenig, Christian,
Can you help me review the new patch below? Thanks!
Kind regards,
Esther
-Original Message-
From: Tong Liu01
Sent: 2022年11月4日星期五 下午7:01
To: amd-gfx@lists.freedesktop.org
Cc: Andrey Grodzovsky ; Quan, Evan
; Chen, Horace ; Tuiko
; Xu, Feifei ; Wang, Yang(Kevin)
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Am 04.11.22 um 09:52 schrieb Tong Liu01:
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve
TMR region firstly to make sure TMR can be allocated a
ack ; Zhang, Hawking ; Liu, Monk
; Xu, Feifei ; Wang, Yang(Kevin)
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Am 04.11.22 um 09:52 schrieb Tong Liu01:
> Move TMR region from top of FB to 2MB for FFBM, so we need to reserve
> TMR region first
Am 04.11.22 um 09:52 schrieb Tong Liu01:
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve TMR region
firstly to make sure TMR can be allocated at 2MB
If I understand it correctly the two methods are mutual exclusive. So I
think you can just extend the existing function in
21 matches
Mail list logo
