RE: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-27 Thread Chen, Guchun
: Grodzovsky, Andrey Sent: Monday, August 23, 2021 10:42 PM To: Christian König ; Chen, Guchun ; Alex Deucher ; Mike Lothian ; Koenig, Christian Cc: amd-gfx list ; Gao, Likun ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-23 Thread Andrey Grodzovsky
your opinion? Regards, Guchun -Original Message- From: Alex Deucher Sent: Friday, August 20, 2021 2:13 AM To: Mike Lothian Cc: Grodzovsky, Andrey ; Chen, Guchun ; amd-gfx list ; Gao, Likun ; Koenig, Christian ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid ove

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-22 Thread Christian König
istian ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2) Please go ahead. Thanks! Alex On Thu, Aug 19, 2021 at 8:05 AM Mike Lothian wrote: Hi Do I need to open a new bug report for this? Cheers Mike On Wed, 18 Au

RE: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-22 Thread Chen, Guchun
d-gfx list ; Gao, Likun ; Koenig, Christian ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2) Please go ahead. Thanks! Alex On Thu, Aug 19, 2021 at 8:05 AM Mike Lothian wrote: > > Hi > > Do I need to ope

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-19 Thread Alex Deucher
Please go ahead. Thanks! Alex On Thu, Aug 19, 2021 at 8:05 AM Mike Lothian wrote: > > Hi > > Do I need to open a new bug report for this? > > Cheers > > Mike > > On Wed, 18 Aug 2021 at 06:26, Andrey Grodzovsky > wrote: >> >> >> On 2021-08-02 1:16 a.m., Guchun Chen wrote: >> > In amdgpu_fence_

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-19 Thread Mike Lothian
Hi Do I need to open a new bug report for this? Cheers Mike On Wed, 18 Aug 2021 at 06:26, Andrey Grodzovsky wrote: > > On 2021-08-02 1:16 a.m., Guchun Chen wrote: > > In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop > > scheduler in s3 test, otherwise, fence related fail

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-17 Thread Andrey Grodzovsky
On 2021-08-02 1:16 a.m., Guchun Chen wrote: In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop scheduler in s3 test, otherwise, fence related failure will arrive after resume. To fix this and for a better clean up, move drm_sched_fini from fence_hw_fini to fence_sw_fini, as

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-17 Thread Mike Lothian
lists.freedesktop.org; Gao, Likun ; Koenig, > Christian ; Zhang, Hawking < > hawking.zh...@amd.com>; Deucher, Alexander > Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in > s3 test (v2) > > On Mon, Aug 2, 2021 at 4:23 AM Chen, Guchun wrote: >

RE: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-02 Thread Chen, Guchun
, Christian ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2) On Mon, Aug 2, 2021 at 4:23 AM Chen, Guchun wrote: > > [Public] > > Thank you, Christian. > > Regarding fence_drv.initialized, it looks

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-02 Thread Mike Lothian
Christian < > christian.koe...@amd.com>; Zhang, Hawking ; > Deucher, Alexander > > Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini > in s3 test (v2) > > > > Am 02.08.21 um 07:16 schrieb Guchun Chen: > > > In amdgpu_fence_driver

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-02 Thread Alex Deucher
esktop.org; Gao, > Likun ; Koenig, Christian ; > Zhang, Hawking ; Deucher, Alexander > > Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 > test (v2) > > Am 02.08.21 um 07:16 schrieb Guchun Chen: > > In amdgpu_fence_driver_hw_fini, no need t

RE: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-02 Thread Chen, Guchun
; Koenig, Christian ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2) Am 02.08.21 um 07:16 schrieb Guchun Chen: > In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop > scheduler in s3 test, oth

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-01 Thread Christian König
Am 02.08.21 um 07:16 schrieb Guchun Chen: In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop scheduler in s3 test, otherwise, fence related failure will arrive after resume. To fix this and for a better clean up, move drm_sched_fini from fence_hw_fini to fence_sw_fini, as it's