RE: [PATCH] drm/amdgpu: handle userptr corner cases with HMM path

2019-03-01 Thread Kuehling, Felix
Since you're addressing two distinct bugs, please split this into two patches. For the multiple VMAs, should we generalize that to handle any number of VMAs? It's not a typical case, but you could easily construct situations with mprotect where different parts of the same buffer have different V

Re: [PATCH] drm/amdgpu: handle userptr corner cases with HMM path

2019-03-04 Thread Yang, Philip
Hi Felix, I will split this and submit two patches for review. I didn't realize mprotect can have userptr with more than 2 vmas. For malloc, it will always be one or two vmas. I will loop over all VMAs to call hmm_vma_fault to get userptr pages. Thanks, Philip On 2019-03-01 7:46 p.m., Kuehlin