Re: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

2022-07-06 Thread Felix Kuehling
Am 2022-07-06 um 12:47 schrieb Ramesh Errabolu: The patch fixes warnings/error as reported by Smatch a static analyzer drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1428 kfd_create_indirect_link_prop() warn: iterator used outside loop: 'cpu_link'

Re: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

2022-07-05 Thread Maíra Canal
de an example. > > Regards, > Ramesh > > -Original Message- > From: Maíra Canal > Sent: Wednesday, June 29, 2022 6:25 PM > To: Errabolu, Ramesh ; > amd-gfx@lists.freedesktop.org; dan.carpen...@oracle.com > Subject: Re: [PATCH] drm/amdkfd: Fix warnings from st

RE: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

2022-07-05 Thread Errabolu, Ramesh
;Signed-off-by" statement. Could you provide an example. Regards, Ramesh -Original Message- From: Maíra Canal Sent: Wednesday, June 29, 2022 6:25 PM To: Errabolu, Ramesh ; amd-gfx@lists.freedesktop.org; dan.carpen...@oracle.com Subject: Re: [PATCH] drm/amdkfd: Fix warnings from st

Re: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

2022-06-29 Thread Maíra Canal
Hi Ramesh, On 6/29/22 14:04, Ramesh Errabolu wrote: > The patch fixes couple of warnings, as reported by Smatch > a static analyzer. > > Fixes: 40d6aa758b13 ("drm/amdkfd: Extend KFD device topology to surface > peer-to-peer links")> > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1428 >

RE: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

2022-06-29 Thread Errabolu, Ramesh
11:13 AM To: Errabolu, Ramesh Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch [CAUTION: External Email] On Tue, Jun 28, 2022 at 06:25:38PM -0500, Ramesh Errabolu wrote: > The patch fixes couple of warnings, as reported by Sma

Re: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

2022-06-29 Thread Dan Carpenter
On Tue, Jun 28, 2022 at 06:25:38PM -0500, Ramesh Errabolu wrote: > The patch fixes couple of warnings, as reported by Smatch > a static analyzer > I had forgotten what the warnings were. Could you put that in the commit message or describe the bug somehow? > Signed-off-by: Ramesh Errabolu >

Re: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

2022-06-29 Thread Dan Carpenter
On Tue, Jun 28, 2022 at 07:41:09PM -0400, Felix Kuehling wrote: > > Am 2022-06-28 um 19:25 schrieb Ramesh Errabolu: > > The patch fixes couple of warnings, as reported by Smatch > > a static analyzer > > > > Signed-off-by: Ramesh Errabolu > > Reported-by: Dan Carpenter > > --- > >

RE: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

2022-06-29 Thread Errabolu, Ramesh
olu, Ramesh ; > amd-gfx@lists.freedesktop.org; dan.carpen...@oracle.com > Subject: Re: [PATCH] drm/amdkfd: Fix warnings from static analyzer > Smatch > > > Am 2022-06-28 um 19:25 schrieb Ramesh Errabolu: >> The patch fixes couple of warnings, as reported by Smatch a static

Re: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

2022-06-29 Thread Felix Kuehling
] drm/amdkfd: Fix warnings from static analyzer Smatch Am 2022-06-28 um 19:25 schrieb Ramesh Errabolu: The patch fixes couple of warnings, as reported by Smatch a static analyzer Signed-off-by: Ramesh Errabolu Reported-by: Dan Carpenter --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 36

RE: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

2022-06-28 Thread Errabolu, Ramesh
[AMD Official Use Only - General] My responses are inline -Original Message- From: Kuehling, Felix Sent: Tuesday, June 28, 2022 6:41 PM To: Errabolu, Ramesh ; amd-gfx@lists.freedesktop.org; dan.carpen...@oracle.com Subject: Re: [PATCH] drm/amdkfd: Fix warnings from static analyzer

Re: [PATCH] drm/amdkfd: Fix warnings from static analyzer Smatch

2022-06-28 Thread Felix Kuehling
Am 2022-06-28 um 19:25 schrieb Ramesh Errabolu: The patch fixes couple of warnings, as reported by Smatch a static analyzer Signed-off-by: Ramesh Errabolu Reported-by: Dan Carpenter --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 36 --- 1 file changed, 19