Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-23 Thread Alex Deucher
; > To: kernel test robot ; Gu, JiaWei (Will) > > ; dri-de...@lists.freedesktop.org; > > amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey > > ; Liu, Monk ; Deng, Emily > > ; Chen, Horace > > Cc: kbuild-...@lists.01.org > > Subject: Re: [PATCH] drm/sch

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-22 Thread Christian König
: Wednesday, February 23, 2022 3:12 PM To: kernel test robot ; Gu, JiaWei (Will) ; dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Liu, Monk ; Deng, Emily ; Chen, Horace Cc: kbuild-...@lists.01.org Subject: Re: [PATCH] drm/sched: Add device pointer

RE: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-22 Thread Gu, JiaWei (Will)
, JiaWei (Will) ; dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey ; Liu, Monk ; Deng, Emily ; Chen, Horace Cc: kbuild-...@lists.01.org Subject: Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler Hi Jiawei, can you take a look at this? The kernel

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-22 Thread Christian König
Hi Jiawei, can you take a look at this? The kernel build robots screaming that this breaks the V3D build. Probably just a typo or missing include. I would rather like to push this sooner than later. Thanks, Christian. Am 21.02.22 um 16:51 schrieb kernel test robot: Hi Jiawei, Thank you

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-21 Thread kernel test robot
Hi Jiawei, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc5 next-20220217] [cannot apply to drm-tip/drm-tip] [If your patch is applied

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-21 Thread kernel test robot
Hi Jiawei, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc5 next-20220217] [cannot apply to drm-tip/drm-tip airlied/drm-next] [If your

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-21 Thread kernel test robot
Hi Jiawei, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc5 next-20220217] [cannot apply to drm-tip/drm-tip] [If your patch is applied

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-21 Thread Christian König
Am 21.02.22 um 10:57 schrieb Jiawei Gu: Add device pointer so scheduler's printing can use DRM_DEV_ERROR() instead, which makes life easier under multiple GPU scenario. v2: amend all calls of drm_sched_init() v3: fill dev pointer for all drm_sched_init() calls Signed-off-by: Jiawei Gu

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-20 Thread Andrey Grodzovsky
On 2022-02-20 22:32, Gu, JiaWei (Will) wrote: [AMD Official Use Only] Pinging. -Original Message- From: Jiawei Gu Sent: Thursday, February 17, 2022 6:44 PM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Koenig, Christian ; Grodzovsky, Andrey ; Liu, Monk ; Deng,

RE: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-20 Thread Gu, JiaWei (Will)
[AMD Official Use Only] Pinging. -Original Message- From: Jiawei Gu Sent: Thursday, February 17, 2022 6:44 PM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Koenig, Christian ; Grodzovsky, Andrey ; Liu, Monk ; Deng, Emily ; Chen, Horace Cc: Gu, JiaWei (Will)

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-17 Thread Christian König
Am 17.02.22 um 11:38 schrieb Jiawei Gu: Add device pointer so scheduler's printing can use DRM_DEV_ERROR() instead, which makes life easier under multiple GPU scenario. v2: amend all calls of drm_sched_init() That looks better, but please send it to the dri-devel mailing list as well.

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-15 Thread Andrey Grodzovsky
Acked-by: Andrey Grodzovsky Andrey On 2022-02-15 06:29, Jiawei Gu wrote: Add device pointer so scheduler's printing can use DRM_DEV_ERROR() instead, which makes life easier under multiple GPU scenario. Signed-off-by: Jiawei Gu --- drivers/gpu/drm/scheduler/sched_main.c | 9 +

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-15 Thread Christian König
In general looks good to me, but Andrey is the maintainer for the GPU scheduler now. Am 15.02.22 um 12:29 schrieb Jiawei Gu: Add device pointer so scheduler's printing can use DRM_DEV_ERROR() instead, which makes life easier under multiple GPU scenario. Signed-off-by: Jiawei Gu ---