Re: [PATCH 05/10] drm/amdgpu:fix memleak in takedown

2017-11-14 Thread Chunming Zhou
On 2017年11月14日 20:00, Christian König wrote: Am 14.11.2017 um 12:52 schrieb Christian König: Am 14.11.2017 um 10:07 schrieb Monk Liu: this can fix the memory leak under the case that not all BO are freed during "takedown" stage, because originally it blocks following kfree on mgr. NAK, all

Re: [PATCH 05/10] drm/amdgpu:fix memleak in takedown

2017-11-14 Thread Christian König
Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: 2017年11月14日 20:01 To: Liu, Monk <monk@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 05/10] drm/amdgpu:fix memleak in takedown Am 14.11.2017 um 12:52 schrieb Christian König: Am 14.11.2017 um 10:07 schrie

RE: [PATCH 05/10] drm/amdgpu:fix memleak in takedown

2017-11-14 Thread Liu, Monk
-EBUSY; >> -} >> - And the worse thing is this "return -EBUSY" would lead to memory leak because it blocks following kfree() on mgr... BR Monk -Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: 2017年11月14日 20:01 To: Liu, Monk <monk..

Re: [PATCH 05/10] drm/amdgpu:fix memleak in takedown

2017-11-14 Thread Christian König
Am 14.11.2017 um 12:52 schrieb Christian König: Am 14.11.2017 um 10:07 schrieb Monk Liu: this can fix the memory leak under the case that not all BO are freed during "takedown" stage, because originally it blocks following kfree on mgr. NAK, all BOs must be freed before we take down at least

Re: [PATCH 05/10] drm/amdgpu:fix memleak in takedown

2017-11-14 Thread Christian König
Am 14.11.2017 um 10:07 schrieb Monk Liu: this can fix the memory leak under the case that not all BO are freed during "takedown" stage, because originally it blocks following kfree on mgr. NAK, all BOs must be freed before we take down at least the GTT manager. That we run into a memory leak