Re: [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

2017-02-13 Thread Samuel Pitoiset
On 02/14/2017 12:46 AM, Tom St Denis wrote: On 02/13/2017 06:40 PM, Samuel Pitoiset wrote: On 02/14/2017 12:17 AM, Tom St Denis wrote: Hi Samuel, Hi Tom, It would be helpful to modify amdgpu_debugfs_sensor_read() to support dpm based sensors as well. This will let me add it to umr.

Re: [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

2017-02-13 Thread Tom St Denis
On 02/13/2017 06:40 PM, Samuel Pitoiset wrote: On 02/14/2017 12:17 AM, Tom St Denis wrote: Hi Samuel, Hi Tom, It would be helpful to modify amdgpu_debugfs_sensor_read() to support dpm based sensors as well. This will let me add it to umr. You mean removing the sanity check (for powerp

Re: [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

2017-02-13 Thread Samuel Pitoiset
On 02/14/2017 12:17 AM, Tom St Denis wrote: Hi Samuel, Hi Tom, It would be helpful to modify amdgpu_debugfs_sensor_read() to support dpm based sensors as well. This will let me add it to umr. You mean removing the sanity check (for powerplay boards)? I can do that in a follow-up patch

Re: [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

2017-02-13 Thread Tom St Denis
Hi Samuel, It would be helpful to modify amdgpu_debugfs_sensor_read() to support dpm based sensors as well. This will let me add it to umr. If you can swing that in here that would be helpful if not I can submit my own patch when this lands. Cheers, Tom On 02/13/2017 05:01 PM, Samuel Pi

Re: [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

2017-02-13 Thread Tom St Denis
On 02/13/2017 05:13 PM, Deucher, Alexander wrote: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Samuel Pitoiset Sent: Monday, February 13, 2017 5:02 PM To: amd-gfx@lists.freedesktop.org Cc: Samuel Pitoiset Subject: [PATCH 1/2] drm/amdgpu: imp

RE: [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

2017-02-13 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Samuel Pitoiset > Sent: Monday, February 13, 2017 5:02 PM > To: amd-gfx@lists.freedesktop.org > Cc: Samuel Pitoiset > Subject: [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre- > powerp