RE: [PATCH 1/2] drm/amdgpu: skip SMU FW reloading in runpm BACO case (v2)

2022-07-13 Thread Deucher, Alexander
---Original Message- > From: Alex Deucher > Sent: Thursday, July 14, 2022 11:44 AM > To: Chen, Guchun > Cc: amd-gfx list ; Deucher, Alexander > ; Zhang, Hawking > ; Lazar, Lijo ; Quan, Evan > ; Feng, Kenneth > Subject: Re: [PATCH 1/2] drm/amdgpu: skip SMU FW reloading in ru

RE: [PATCH 1/2] drm/amdgpu: skip SMU FW reloading in runpm BACO case (v2)

2022-07-13 Thread Chen, Guchun
Lijo ; Quan, Evan ; Feng, Kenneth Subject: Re: [PATCH 1/2] drm/amdgpu: skip SMU FW reloading in runpm BACO case (v2) On Wed, Jul 13, 2022 at 11:15 PM Chen, Guchun wrote: > > Re: I think this would be better as: > if (adev->in_runpm && (adev->pm.rpm_mode != AMDGPU_RUNPM_BOCO

Re: [PATCH 1/2] drm/amdgpu: skip SMU FW reloading in runpm BACO case (v2)

2022-07-13 Thread Alex Deucher
Lijo ; Quan, Evan ; Feng, Kenneth > > Subject: Re: [PATCH 1/2] drm/amdgpu: skip SMU FW reloading in runpm BACO case > (v2) > > On Tue, Jul 12, 2022 at 11:18 PM Guchun Chen wrote: > > > > SMU is always alive, so it's fine to skip SMU FW reloading when runpm > >

RE: [PATCH 1/2] drm/amdgpu: skip SMU FW reloading in runpm BACO case (v2)

2022-07-13 Thread Chen, Guchun
runtime cycle. Regards, Guchun -Original Message- From: Alex Deucher Sent: Wednesday, July 13, 2022 11:31 PM To: Chen, Guchun Cc: amd-gfx list ; Deucher, Alexander ; Zhang, Hawking ; Lazar, Lijo ; Quan, Evan ; Feng, Kenneth Subject: Re: [PATCH 1/2] drm/amdgpu: skip SMU FW reloading

Re: [PATCH 1/2] drm/amdgpu: skip SMU FW reloading in runpm BACO case (v2)

2022-07-13 Thread Alex Deucher
On Tue, Jul 12, 2022 at 11:18 PM Guchun Chen wrote: > > SMU is always alive, so it's fine to skip SMU FW reloading > when runpm resumed from BACO, this can avoid some race issues > when resuming SMU FW. > > v2: Exclude boco case if an ASIC supports both boco and baco > > Suggested-by: Evan Quan >

RE: [PATCH 1/2] drm/amdgpu: skip SMU FW reloading in runpm BACO case

2022-07-11 Thread Chen, Guchun
; Feng, Kenneth Subject: Re: [PATCH 1/2] drm/amdgpu: skip SMU FW reloading in runpm BACO case On Mon, Jul 11, 2022 at 9:58 AM Guchun Chen wrote: > > SMU is always alive, so it's fine to skip SMU FW reloading when runpm > resumed from BACO, this can avoid some race issues when resu

Re: [PATCH 1/2] drm/amdgpu: skip SMU FW reloading in runpm BACO case

2022-07-11 Thread Alex Deucher
On Mon, Jul 11, 2022 at 9:58 AM Guchun Chen wrote: > > SMU is always alive, so it's fine to skip SMU FW reloading > when runpm resumed from BACO, this can avoid some race issues > when resuming SMU FW. > > Suggested-by: Evan Quan > Signed-off-by: Guchun Chen > --- > drivers/gpu/drm/amd/amdgpu/a