Re: [PATCH 1/2] drm/amdkfd: Add queue to MES if it becomes active

2022-06-17 Thread philip yang
On 2022-06-16 10:49, Eric Huang wrote: Does it break the case of q->gws with q->properties.is_active == true? Thanks for catching this, it breaks pqm_set_gws, I will revert this and send v2 for review. Regards, Philip

Re: [PATCH 1/2] drm/amdkfd: Add queue to MES if it becomes active

2022-06-16 Thread Eric Huang
Does it break the case of q->gws with q->properties.is_active == true? Regards, Eric On 2022-06-15 17:56, Philip Yang wrote: We remove the user queue from MES scheduler to update queue properties. If the queue becomes active after updating, add the user queue to MES scheduler, to be able to han

RE: [PATCH 1/2] drm/amdkfd: Add queue to MES if it becomes active

2022-06-15 Thread Sider, Graham
[Public] Reviewed-by: Graham Sider > -Original Message- > From: Yang, Philip > Sent: Wednesday, June 15, 2022 5:57 PM > To: amd-gfx@lists.freedesktop.org > Cc: Sider, Graham ; Yang, Philip > > Subject: [PATCH 1/2] drm/amdkfd: Add queue to MES if it becomes active > > We remove the us