Re: [PATCH 1/3] drm/amd/amdgpu: Add wave reader to debugfs

2016-10-14 Thread StDenis, Tom
: Re: [PATCH 1/3] drm/amd/amdgpu: Add wave reader to debugfs Hi Nicolai, I was trying to avoid having ASIC specific includes/etc in the amdgpu_device.c file. Agreed that de-numberifying it would be nice. Maybe we can add some /**/ comments to clear it up. I imagine in the future we'l

RE: [PATCH 1/3] drm/amd/amdgpu: Add wave reader to debugfs

2016-10-14 Thread Deucher, Alexander
] drm/amd/amdgpu: Add wave reader to debugfs Hi Nicolai, I was trying to avoid having ASIC specific includes/etc in the amdgpu_device.c file. Agreed that de-numberifying it would be nice. Maybe we can add some /**/ comments to clear it up. I imagine in the future we'll add more fields

Re: [PATCH 1/3] drm/amd/amdgpu: Add wave reader to debugfs

2016-10-14 Thread StDenis, Tom
Tom From: Nicolai Hähnle Sent: Friday, October 14, 2016 03:25 To: Tom St Denis; amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: Re: [PATCH 1/3] drm/amd/amdgpu: Add wave reader to debugfs On 11.10.2016 21:18, Tom St Denis wrote: > Currently suppor

Re: [PATCH 1/3] drm/amd/amdgpu: Add wave reader to debugfs

2016-10-14 Thread Nicolai Hähnle
On 11.10.2016 21:18, Tom St Denis wrote: Currently supports CZ/VI. Allows nearly atomic read of wave data from GPU. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/drivers/gpu/drm/am