RE: [PATCH 2/2] drm/amd/powerplay: Enable "disable dpm" feature for vega20 power functions.

2019-05-14 Thread Zhang, Hawking
, Jack Sent: 2019年5月13日 11:26 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 2/2] drm/amd/powerplay: Enable "disable dpm" feature for vega20 power functions. Hi Hawking, If no other tools (sysfs inferfaces have been controlled by adev->dpm_enabled) directl

RE: [PATCH 2/2] drm/amd/powerplay: Enable "disable dpm" feature for vega20 power functions.

2019-05-12 Thread Gui, Jack
Gui, Jack ; amd-gfx@lists.freedesktop.org Cc: Gui, Jack Subject: RE: [PATCH 2/2] drm/amd/powerplay: Enable "disable dpm" feature for vega20 power functions. I'm wondering whether we are able to handle all asic specific ppt function gracefully. Add pm_enable check into ppt functions wo

RE: [PATCH 2/2] drm/amd/powerplay: Enable "disable dpm" feature for vega20 power functions.

2019-05-11 Thread Zhang, Hawking
I'm wondering whether we are able to handle all asic specific ppt function gracefully. Add pm_enable check into ppt functions would be boring since we have to do similar jobs for each ASIC. Instead, is it possible to return early from amdgpu_smu interface level? Take smu_handle_task for the