Re: [PATCH 2/3] drm/amdgpu: Add SPSC queue to scheduler.

2017-10-23 Thread Christian König
Am 20.10.2017 um 15:32 schrieb Andrey Grodzovsky: It is intended to sabstitute the bounded fifo we are currently using. Signed-off-by: Andrey Grodzovsky Two style nit picks below, with those fixed the patch is Reviewed-by: Christian König

Re: [PATCH 2/3] drm/amdgpu: Add SPSC queue to scheduler.

2017-10-23 Thread Andrey Grodzovsky
On 2017-10-23 12:06 AM, Liu, Monk wrote: If the deadlock issue could be solved I don't see why we give up kfifo and switch to SPSC .. The deadlock is solved because we don't block anymore waiting for consumer to dequeue items from the queue - which can only be achieved with not

RE: [PATCH 2/3] drm/amdgpu: Add SPSC queue to scheduler.

2017-10-22 Thread Liu, Monk
If the deadlock issue could be solved I don't see why we give up kfifo and switch to SPSC .. -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Andrey Grodzovsky Sent: 2017年10月20日 21:32 To: amd-gfx@lists.freedesktop.org Cc: Grodzovsky,