Re: [PATCH 4/8] drm/amd/pp: Clean up the code for RV in powerplay

On Wed, Mar 7, 2018 at 11:42 PM, Zhu, Rex wrote: >>Is this consistent with our other smu implementations? If we never use the >>errors, I'm ok with removing them, but I don't want to have to add them again >>later if we decide we >>actually need them. > > Rex: until

RE: [PATCH 4/8] drm/amd/pp: Clean up the code for RV in powerplay

>Is this consistent with our other smu implementations? If we never use the >errors, I'm ok with removing them, but I don't want to have to add them again >later if we decide we >actually need them. Rex: until vega10/raven, we do not handle the errors in windows/linux, just print out the

Re: [PATCH 4/8] drm/amd/pp: Clean up the code for RV in powerplay

On Wed, Mar 7, 2018 at 5:46 AM, Rex Zhu wrote: > In send_message_to_smu helper functions, > Print out the error code for debug if smu failed to response. > > and the helper functions always return true, so no need to > check their return value. > > Signed-off-by: Rex Zhu