RE: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic

2018-11-23 Thread Zeng, Oak
d-gfx list Subject: Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic The main idea is to be able to use different layouts on different asics that may share the same IP code. Alex From: amd-gfx mailto:amd-gfx

Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic

2018-11-23 Thread Deucher, Alexander
eucher >> Sent: Wednesday, November 21, 2018 11:22 AM >> To: Zeng, Oak >> Cc: Zeng, Oak ; amd-gfx list >> >> Subject: Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and >> future asic >> >> On Wed, Nov 21, 2018 at 10:52 AM Oak Zeng

RE: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic

2018-11-22 Thread Zeng, Oak
Hi Alex/Felix, This is a modified version based on your feedback. Do you have more comment? Regards, Oak -Original Message- From: Zeng, Oak Sent: Wednesday, November 21, 2018 5:01 PM To: amd-gfx@lists.freedesktop.org Cc: Zeng, Oak Subject: [PATCH 7/7] drm/amdgpu: Use new doorbell lay

Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic

2018-11-22 Thread Christian König
Christian. Alex thanks, Oak -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, November 21, 2018 11:22 AM To: Zeng, Oak Cc: Zeng, Oak ; amd-gfx list Subject: Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic On Wed, Nov 21, 201

Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic

2018-11-21 Thread Alex Deucher
On Wed, Nov 21, 2018 at 5:00 PM Oak Zeng wrote: > > v2: Use enum definition instead of hardcoded value > > Change-Id: I04d22fb717ac50483c0835f160a2e860e344f358 > Signed-off-by: Oak Zeng > Suggested-by: Felix Kuehling > Suggested-by: Alex Deucher This patch should come before patch 5 so we upda

Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic

2018-11-21 Thread Alex Deucher
; Cc: Zeng, Oak ; amd-gfx list > Subject: Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and > future asic > > On Wed, Nov 21, 2018 at 10:52 AM Oak Zeng wrote: > > > > Change-Id: I04d22fb717ac50483c0835f160a2e860e344f358 > > Signed-off-by: Oak Zeng >

RE: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic

2018-11-21 Thread Zeng, Oak
- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, November 21, 2018 11:22 AM To: Zeng, Oak Cc: Zeng, Oak ; amd-gfx list Subject: Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic On Wed, Nov 21, 2018 at 10:52 AM Oak Zeng wrote: > &g

RE: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic

2018-11-21 Thread Zeng, Oak
- From: amd-gfx On Behalf Of Liu, Shaoyun Sent: Wednesday, November 21, 2018 11:10 AM To: Zeng, Oak ; amd-gfx@lists.freedesktop.org Cc: Zeng, Oak Subject: Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic The doorbell index defines should be compatible with what is used

Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic

2018-11-21 Thread Alex Deucher
On Wed, Nov 21, 2018 at 10:52 AM Oak Zeng wrote: > > Change-Id: I04d22fb717ac50483c0835f160a2e860e344f358 > Signed-off-by: Oak Zeng > Suggested-by: Felix Kuehling > Suggested-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/Makefile| 4 +- > drivers/gpu/drm/amd/amdgpu/amdgp

Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic

2018-11-21 Thread Liu, Shaoyun
The doorbell index defines should be compatible with what is used in windows driver .  I don't see the  necessary to introduce the new init file for this instead of use the original MACRO defines. We  need to coordinate with windows driver team for a new user queue SDMA doorbell range and used