Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-11-29 Thread Felix Kuehling
On 2019-10-11 1:12 p.m., t...@kernel.org wrote: Hello, Daniel. On Wed, Oct 09, 2019 at 06:06:52PM +0200, Daniel Vetter wrote: That's not the point I was making. For cpu cgroups there's a very well defined connection between the cpu bitmasks/numbers in cgroups and the cpu bitmasks you use in var

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-11 Thread t...@kernel.org
Hello, Daniel. On Wed, Oct 09, 2019 at 06:06:52PM +0200, Daniel Vetter wrote: > That's not the point I was making. For cpu cgroups there's a very well > defined connection between the cpu bitmasks/numbers in cgroups and the cpu > bitmasks you use in various system calls (they match). And that stuf

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Daniel Vetter
On Wed, Oct 9, 2019 at 8:52 PM Greathouse, Joseph wrote: > > > From: Daniel Vetter On Behalf Of Daniel Vetter > > Sent: Wednesday, October 9, 2019 11:07 AM > > On Wed, Oct 09, 2019 at 03:53:42PM +, Kuehling, Felix wrote: > > > On 2019-10-09 11:34, Daniel Vetter wrote: > > > > On Wed, Oct 09,

RE: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Greathouse, Joseph
> From: Daniel Vetter On Behalf Of Daniel Vetter > Sent: Wednesday, October 9, 2019 11:07 AM > On Wed, Oct 09, 2019 at 03:53:42PM +, Kuehling, Felix wrote: > > On 2019-10-09 11:34, Daniel Vetter wrote: > > > On Wed, Oct 09, 2019 at 03:25:22PM +, Kuehling, Felix wrote: > > >> On 2019-10-09

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Daniel Vetter
On Wed, Oct 09, 2019 at 03:53:42PM +, Kuehling, Felix wrote: > On 2019-10-09 11:34, Daniel Vetter wrote: > > On Wed, Oct 09, 2019 at 03:25:22PM +, Kuehling, Felix wrote: > >> On 2019-10-09 6:31, Daniel Vetter wrote: > >>> On Tue, Oct 08, 2019 at 06:53:18PM +, Kuehling, Felix wrote: > >>

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Kuehling, Felix
On 2019-10-09 11:34, Daniel Vetter wrote: > On Wed, Oct 09, 2019 at 03:25:22PM +, Kuehling, Felix wrote: >> On 2019-10-09 6:31, Daniel Vetter wrote: >>> On Tue, Oct 08, 2019 at 06:53:18PM +, Kuehling, Felix wrote: The description sounds reasonable to me and maps well to the CU masking

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Daniel Vetter
On Wed, Oct 09, 2019 at 03:25:22PM +, Kuehling, Felix wrote: > On 2019-10-09 6:31, Daniel Vetter wrote: > > On Tue, Oct 08, 2019 at 06:53:18PM +, Kuehling, Felix wrote: > >> > >> The description sounds reasonable to me and maps well to the CU masking > >> feature in our GPUs. > >> > >> It w

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Kuehling, Felix
On 2019-10-09 6:31, Daniel Vetter wrote: > On Tue, Oct 08, 2019 at 06:53:18PM +, Kuehling, Felix wrote: >> >> The description sounds reasonable to me and maps well to the CU masking >> feature in our GPUs. >> >> It would also allow us to do more coarse-grained masking for example to >> guarante

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Daniel Vetter
On Wed, Oct 09, 2019 at 11:08:45AM -0400, Kenny Ho wrote: > Hi Daniel, > > Can you elaborate what you mean in more details? The goal of lgpu is > to provide the ability to subdivide a GPU device and give those slices > to different users as needed. I don't think there is anything > controversial

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Kenny Ho
Hi Daniel, Can you elaborate what you mean in more details? The goal of lgpu is to provide the ability to subdivide a GPU device and give those slices to different users as needed. I don't think there is anything controversial or vendor specific here as requests for this are well documented. Th

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-09 Thread Daniel Vetter
On Tue, Oct 08, 2019 at 06:53:18PM +, Kuehling, Felix wrote: > On 2019-08-29 2:05 a.m., Kenny Ho wrote: > > drm.lgpu > > A read-write nested-keyed file which exists on all cgroups. > > Each entry is keyed by the DRM device's major:minor. > > > > lgpu stands for logica

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

2019-10-08 Thread Kuehling, Felix
On 2019-08-29 2:05 a.m., Kenny Ho wrote: > drm.lgpu > A read-write nested-keyed file which exists on all cgroups. > Each entry is keyed by the DRM device's major:minor. > > lgpu stands for logical GPU, it is an abstraction used to > subdivide a physical DRM devic