Am 09.08.2018 um 05:19 schrieb Junwei Zhang:
a helper function to create and initialize amdgpu bo
Signed-off-by: Junwei Zhang
---
amdgpu/amdgpu_bo.c | 184 -
1 file changed, 84 insertions(+), 100 deletions(-)
diff --git a/amdgpu/amdgpu_bo.
Comments inline.
Regards,
Qiang
From: amd-gfx on behalf of Junwei Zhang
Sent: Thursday, August 9, 2018 11:19 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Jerry; Koenig, Christian
Subject: [PATCH libdrm] amdgpu: add a function to create amdgpu bo inter
On 08/09/2018 03:40 PM, Yu, Qiang wrote:
Comments inline.
Regards,
Qiang
From: amd-gfx on behalf of Junwei Zhang
Sent: Thursday, August 9, 2018 11:19 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Jerry; Koenig, Christian
Subject: [PATCH libdrm] amdgp
> + r = amdgpu_bo_create(dev, alloc_buffer->alloc_size, args.out.handle,
> +buf_handle);
> if (r)
> - amdgpu_bo_free(bo);
> - else
> - *buf_handle = bo;
> + goto out;
> [yuq] the handle is not freed.
Do yo
>
>
> > + r = amdgpu_bo_create(dev, alloc_buffer->alloc_size, args.out.handle,
> > +buf_handle);
> > if (r)
> > - amdgpu_bo_free(bo);
> > - else
> > - *buf_handle = bo;
> > + goto out;
> > [yuq] the handle
Am 09.08.2018 um 11:29 schrieb Junwei Zhang:
a helper function to create and initialize amdgpu bo
v2: update error handling: add label and free bo
Signed-off-by: Junwei Zhang
---
amdgpu/amdgpu_bo.c | 186 +
1 file changed, 89 insertions(+)
Am 13.08.2018 um 07:18 schrieb Junwei Zhang:
a helper function to create and initialize amdgpu bo
v2: update error handling: add label and free bo
v3: update error handling: separate each error label
Signed-off-by: Junwei Zhang
---
amdgpu/amdgpu_bo.c | 196 ++-
Am 13.08.2018 um 12:06 schrieb Junwei Zhang:
a helper function to create and initialize amdgpu bo
v2: update error handling: add label and free bo
v3: update error handling: separate each error label
v4: update error handling and free flink bo in bo import
Signed-off-by: Junwei Zhang
A separ
On 08/13/2018 06:14 PM, Christian König wrote:
Am 13.08.2018 um 12:06 schrieb Junwei Zhang:
a helper function to create and initialize amdgpu bo
v2: update error handling: add label and free bo
v3: update error handling: separate each error label
v4: update error handling and free flink bo in b
