On Wed, May 06, 2020 at 10:10:56AM +, Pan, Xinhui wrote:
> [AMD Official Use Only - Internal Distribution Only]
>
> no. below function checks if block is valid or not.
> I think you need check your code_checker. or you were checking on a very old
> codebase?
>
> /* check if ras is supported
(struct amdgpu_device *adev,
unsigned int block)
From: Dan Carpenter
Sent: Wednesday, May 6, 2020 5:17:34 PM
To: Zhou1, Tao
Cc: Pan, Xinhui ; amd-gfx@lists.freedesktop.org
Subject: Re: [bug report] drm/amdgpu: add amdgpu_ras.c to support ras (v2)
On Wed, May 06
On Wed, May 06, 2020 at 07:26:16AM +, Zhou1, Tao wrote:
> [AMD Public Use]
>
> Hi Dan:
>
> Please check the following piece of code in
> amdgpu_ras_debugfs_ctrl_parse_data:
>
> if (op != -1) {
> if (amdgpu_ras_find_block_id_by_name(block_name, &block_id))
>
[AMD Public Use]
Hi Dan:
Please check the following piece of code in amdgpu_ras_debugfs_ctrl_parse_data:
if (op != -1) {
if (amdgpu_ras_find_block_id_by_name(block_name, &block_id))
return -EINVAL;
data->head.block = block_id;
amd
Here are a couple more:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:534 amdgpu_ras_is_feature_allowed()
error: undefined (user controlled) shift '(((1))) << (head->block)'
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:542 amdgpu_ras_is_feature_enabled()
error: undefined (user controlled) shift '(((1))) <<
