Re: [PATCH] drm/amd/display: add basic atomic check for cursor plane

2020-05-04 Thread Simon Ser
Hi, On Monday, March 30, 2020 5:23 PM, Simon Ser wrote: > On Monday, March 30, 2020 5:18 PM, Kazlauskas, Nicholas > nicholas.kazlaus...@amd.com wrote: > > > On 2020-03-30 9:13 a.m., Simon Ser wrote: > > > > > On Monday, March 30, 2020 3:11 PM, Kazlauskas, Nicholas > > >

Re: [PATCH] drm/amd/display: add basic atomic check for cursor plane

2020-03-30 Thread Simon Ser
On Monday, March 30, 2020 5:18 PM, Kazlauskas, Nicholas wrote: > On 2020-03-30 9:13 a.m., Simon Ser wrote: > > > On Monday, March 30, 2020 3:11 PM, Kazlauskas, Nicholas > > nicholas.kazlaus...@amd.com wrote: > > > > > On 2020-03-30 9:02 a.m., Simon Ser wrote: > > > > > > > On Monday, March 30,

Re: [PATCH] drm/amd/display: add basic atomic check for cursor plane

2020-03-30 Thread Kazlauskas, Nicholas
On 2020-03-30 9:13 a.m., Simon Ser wrote: On Monday, March 30, 2020 3:11 PM, Kazlauskas, Nicholas wrote: On 2020-03-30 9:02 a.m., Simon Ser wrote: On Monday, March 30, 2020 2:59 PM, Kazlauskas, Nicholas nicholas.kazlaus...@amd.com wrote: We've been doing these checks for position before

Re: [PATCH] drm/amd/display: add basic atomic check for cursor plane

2020-03-30 Thread Simon Ser
On Monday, March 30, 2020 3:11 PM, Kazlauskas, Nicholas wrote: > On 2020-03-30 9:02 a.m., Simon Ser wrote: > > > On Monday, March 30, 2020 2:59 PM, Kazlauskas, Nicholas > > nicholas.kazlaus...@amd.com wrote: > > > > > We've been doing these checks for position before but I don't think we > > >

Re: [PATCH] drm/amd/display: add basic atomic check for cursor plane

2020-03-30 Thread Kazlauskas, Nicholas
On 2020-03-30 9:02 a.m., Simon Ser wrote: On Monday, March 30, 2020 2:59 PM, Kazlauskas, Nicholas wrote: We've been doing these checks for position before but I don't think we really need them. DC should be disabling the cursor when we ask for a position completely off the screen. I think

Re: [PATCH] drm/amd/display: add basic atomic check for cursor plane

2020-03-30 Thread Simon Ser
On Monday, March 30, 2020 2:59 PM, Kazlauskas, Nicholas wrote: > We've been doing these checks for position before but I don't think we > really need them. DC should be disabling the cursor when we ask for a > position completely off the screen. > > I think that's better than rejecting the

Re: [PATCH] drm/amd/display: add basic atomic check for cursor plane

2020-03-30 Thread Kazlauskas, Nicholas
On 2020-03-30 5:23 a.m., Simon Ser wrote: This patch adds a basic cursor check when an atomic test-only commit is performed. The position and size of the cursor plane is checked. This should fix user-space relying on atomic checks to assign buffers to planes. Signed-off-by: Simon Ser