Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-21 Thread Kurt Kartaltepe
On Wed, Mar 20, 2024 at 6:31 AM Christian König wrote: > Can you provide the full output of lspci -. As far as I can see that > doesn't looks so invalid to me. I've added the relevant pci probing debug output without assign-busses and the lspci - for a boot with all devices visible.

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-20 Thread Christian König
Am 19.03.24 um 16:04 schrieb Kurt Kartaltepe: On Tue, Mar 19, 2024 at 2:54 AM Christian König wrote: Well what problems do you run into? The ACPI and BIOS assignments usually work much better than whatever the Linux PCI subsystem comes up with. Perhaps its easier to show the lspci output

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-20 Thread Kurt Kartaltepe
On Tue, Mar 19, 2024 at 2:54 AM Christian König wrote: > > > Well what problems do you run into? The ACPI and BIOS assignments > usually work much better than whatever the Linux PCI subsystem comes up > with. Perhaps its easier to show the lspci output for the BIOS assignment and we can agree

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-19 Thread Christian König
Am 19.03.24 um 02:55 schrieb Kurt Kartaltepe: On Mon, Mar 18, 2024 at 12:57 PM Alex Deucher wrote: On Mon, Mar 18, 2024 at 3:52 PM Alex Deucher wrote: ... Depends on the platform, but recent ones use VFCT. That said, there should only ever be one IGPU in the system so I think we could just

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-19 Thread Kurt Kartaltepe
On Mon, Mar 18, 2024 at 8:42 AM Alex Deucher wrote: > > On Mon, Mar 18, 2024 at 10:19 AM Kurt Kartaltepe > wrote: > > > > On Mon, Mar 18, 2024 at 6:37 AM Alex Deucher wrote: > > > > > > On Mon, Mar 18, 2024 at 4:47 AM Kurt Kartaltepe > > > wrote: > > > > > > > > These checks prevent using

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-19 Thread Kurt Kartaltepe
On Mon, Mar 18, 2024 at 12:57 PM Alex Deucher wrote: > > On Mon, Mar 18, 2024 at 3:52 PM Alex Deucher wrote: > > ... > > Depends on the platform, but recent ones use VFCT. That said, there > > should only ever be one IGPU in the system so I think we could just > > rely on the VID and DID for

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-19 Thread Kurt Kartaltepe
On Mon, Mar 18, 2024 at 6:37 AM Alex Deucher wrote: > > On Mon, Mar 18, 2024 at 4:47 AM Kurt Kartaltepe wrote: > > > > These checks prevent using amdgpu with the pcie=assign-busses parameter > > which will re-address devices from their acpi values. > > > > Signed-off-by: Kurt Kartaltepe > >

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-18 Thread Alex Deucher
On Mon, Mar 18, 2024 at 3:52 PM Alex Deucher wrote: > > On Mon, Mar 18, 2024 at 12:06 PM Kurt Kartaltepe > wrote: > > > > On Mon, Mar 18, 2024 at 8:42 AM Alex Deucher wrote: > > > > > > On Mon, Mar 18, 2024 at 10:19 AM Kurt Kartaltepe > > > wrote: > > > > > > > > On Mon, Mar 18, 2024 at 6:37 

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-18 Thread Alex Deucher
On Mon, Mar 18, 2024 at 12:06 PM Kurt Kartaltepe wrote: > > On Mon, Mar 18, 2024 at 8:42 AM Alex Deucher wrote: > > > > On Mon, Mar 18, 2024 at 10:19 AM Kurt Kartaltepe > > wrote: > > > > > > On Mon, Mar 18, 2024 at 6:37 AM Alex Deucher > > > wrote: > > > > > > > > On Mon, Mar 18, 2024 at

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-18 Thread Alex Deucher
On Mon, Mar 18, 2024 at 10:19 AM Kurt Kartaltepe wrote: > > On Mon, Mar 18, 2024 at 6:37 AM Alex Deucher wrote: > > > > On Mon, Mar 18, 2024 at 4:47 AM Kurt Kartaltepe > > wrote: > > > > > > These checks prevent using amdgpu with the pcie=assign-busses parameter > > > which will re-address

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-18 Thread Alex Deucher
On Mon, Mar 18, 2024 at 4:47 AM Kurt Kartaltepe wrote: > > These checks prevent using amdgpu with the pcie=assign-busses parameter > which will re-address devices from their acpi values. > > Signed-off-by: Kurt Kartaltepe This will likely break multi-GPU functionality. The BDF values are how