RE: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-11-07 Thread Quan, Evan
[AMD Official Use Only] Thanks Boris. BR Evan > -Original Message- > From: Borislav Petkov > Sent: Friday, November 5, 2021 7:24 PM > To: Quan, Evan > Cc: amd-gfx list ; Lazar, Lijo > ; Deucher, Alexander > > Subject: Re: bf756fb833cb ("drm/amdgpu: add m

Re: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-11-05 Thread Borislav Petkov
On Fri, Nov 05, 2021 at 08:05:41AM +, Quan, Evan wrote: > I'm wondering are you able to give the attached patch(alone) a try. Yap, looks good. Tested-by: Borislav Petkov -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

RE: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-15 Thread Quan, Evan
; Subject: Re: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 > UVD/VCE on suspend") > > On Thu, Oct 14, 2021 at 02:02:48AM +, Quan, Evan wrote: > > [Quan, Evan] Yes, but not(apply them) at the same time. One by one as > you did before. > > - try the

Re: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-14 Thread Borislav Petkov
On Thu, Oct 14, 2021 at 02:02:48AM +, Quan, Evan wrote: > [Quan, Evan] Yes, but not(apply them) at the same time. One by one as you did > before. > - try the patch1 first Ok, first patch worked fine. > - undo the changes of patch1 and try patch2 Did that, worked fine too except after the

RE: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-13 Thread Quan, Evan
; Subject: Re: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 > UVD/VCE on suspend") > > On Wed, Oct 13, 2021 at 09:19:45AM +, Quan, Evan wrote: > > So, I need your help to confirm the last two patches(I sent you) do not > affect the fix for the bug above

Re: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-13 Thread Borislav Petkov
On Wed, Oct 13, 2021 at 09:19:45AM +, Quan, Evan wrote: > So, I need your help to confirm the last two patches(I sent you) do not > affect the fix for the bug above. > Please follow the steps below to verify it: > 1. Launch a video playing > 2. open another terminal and issue "sudo

RE: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-13 Thread Quan, Evan
nal Message- > From: Borislav Petkov > Sent: Tuesday, October 12, 2021 1:09 AM > To: Quan, Evan > Cc: Alex Deucher ; amd-gfx list g...@lists.freedesktop.org>; LKML ; Deucher, > Alexander ; Pan, Xinhui > ; Chen, Guchun > Subject: Re: bf756fb833cb ("drm/amdgpu: add

Re: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-11 Thread Borislav Petkov
On Mon, Oct 11, 2021 at 08:03:51AM +, Quan, Evan wrote: > OK... Then forget about previous patches. Let's try to narrow down the > issue first. Please try the attached patch1 first. If it works, It does. > please undo the changes of patch1 and try patch2 to narrow down further. It does too.

RE: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-11 Thread Quan, Evan
Petkov > Sent: Saturday, October 9, 2021 6:07 PM > To: Quan, Evan > Cc: Alex Deucher ; amd-gfx list g...@lists.freedesktop.org>; LKML ; Deucher, > Alexander ; Pan, Xinhui > ; Chen, Guchun > Subject: Re: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 > UV

Re: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-11 Thread Borislav Petkov
On Sat, Oct 09, 2021 at 09:54:13AM +, Quan, Evan wrote: > Oops, I just found some necessary changes are missing from the patch of the > link below. > https://lists.freedesktop.org/archives/amd-gfx/2021-September/069006.html > > Could you try the patch from the link above + the attached

Re: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-11 Thread Borislav Petkov
On Sat, Oct 09, 2021 at 01:20:39AM +, Quan, Evan wrote: > Maybe the change below can address your issue. > https://lists.freedesktop.org/archives/amd-gfx/2021-September/069006.html Nope, that one doesn't change anything. Thx. -- Regards/Gruss, Boris.

RE: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-09 Thread Quan, Evan
age- > From: Borislav Petkov > Sent: Saturday, October 9, 2021 5:01 PM > To: Quan, Evan > Cc: Alex Deucher ; amd-gfx list g...@lists.freedesktop.org>; LKML ; Deucher, > Alexander ; Pan, Xinhui > ; Chen, Guchun > Subject: Re: bf756fb833cb ("drm/amdgpu: add missing

RE: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-08 Thread Quan, Evan
Evan ; amd-gfx list g...@lists.freedesktop.org>; LKML ; Deucher, > Alexander ; Pan, Xinhui > ; Chen, Guchun > Subject: Re: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 > UVD/VCE on suspend") > > On Fri, Oct 08, 2021 at 11:12:35AM -0400, Alex Deu

Re: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-08 Thread Borislav Petkov
On Fri, Oct 08, 2021 at 11:12:35AM -0400, Alex Deucher wrote: > Can you try swapping the order of > amdgpu_device_ip_set_powergating_state() and > amdgpu_device_ip_set_clockgating_state() in the patch? Nope, the diff below didn't change things. Should I comment them out one by one and see

bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-07 Thread Borislav Petkov
Hi folks, commit in $Subject breaks rebooting an HP laptop here with a Carrizo chipset: after typing "reboot" and pressing Enter, it powers off the machine up to a certain point but the fans remain on, screen goes black and nothing happens anymore. No reboot. I have to power it off by holding the