[PATCH] drm/amdgpu: PWRBRK sequence changes for Aldebaran

2021-06-09 Thread Ashish Pawar
Modify power brake enablement sequence on Aldebaran Signed-off-by: Ashish Pawar --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c index c0352dcc89be..1769c4cba2ad

Re: [PATCH] drm: display: Remove duplicated argument in dcn31

2021-06-09 Thread Rodrigo Siqueira
On 06/09, Wan Jiabing wrote: > Fix the following coccicheck warning: > ./drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c: > 3539:12-42: duplicated argument to && or || > ./drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c: > 5677:87-123: duplicated argument to && or ||

Re: [PATCH] drm: display: Remove duplicate include in dce110

2021-06-09 Thread Rodrigo Siqueira
On 06/08, Wan Jiabing wrote: > Fix the following checkincludes.pl warning: > ./drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c > 35 #include "dce110_hw_sequencer.h" > 69 #include "dce110_hw_sequencer.h" > > > Signed-off-by: Wan Jiabing > --- >

Important:: Action required lists.freedesktop.org

2021-06-09 Thread Email ADMIN
  lists.freedesktop.org We just received  request to deactivate your email account listed below. Your email is:   amd-gfx@lists.freedesktop.org Within 24 hours, all email data associated with your account will be deleted from our servers and your account will be permanently 

[PATCH v2 7/7] drm/connector: add ref to drm_connector_get in iter docs

2021-06-09 Thread Simon Ser
Mention that connectors need to be referenced manually if they are to be accessed after the iteration has progressed or ended. Signed-off-by: Simon Ser --- include/drm/drm_connector.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/drm/drm_connector.h

[PATCH v2 6/7] i915/display/dp: send a more fine-grained link-status uevent

2021-06-09 Thread Simon Ser
When link-status changes, send a hotplug uevent which contains the connector and property ID. That way, user-space can more easily figure out that only the link-status property of this connector has been updated. Signed-off-by: Simon Ser --- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ 1

[PATCH v2 5/7] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-06-09 Thread Simon Ser
If an hotplug event only updates a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_probe_helper.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git

[PATCH v2 4/7] amdgpu: use drm_kms_helper_connector_hotplug_event

2021-06-09 Thread Simon Ser
When updating a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Signed-off-by: Simon Ser --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 ++-- 2 files

[PATCH v2 3/7] drm/connector: use drm_sysfs_connector_hotplug_event

2021-06-09 Thread Simon Ser
In drm_connector_register, use drm_sysfs_connector_hotplug_event instead of drm_sysfs_hotplug_event, because the hotplug event only updates a single connector. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 2/7] drm/probe-helper: add drm_kms_helper_connector_hotplug_event

2021-06-09 Thread Simon Ser
This function is the same as drm_kms_helper_hotplug_event, but takes a connector instead of a device. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_probe_helper.c | 23 +++ include/drm/drm_probe_helper.h | 1 + 2 files changed, 24 insertions(+) diff --git

[PATCH v2 1/7] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-06-09 Thread Simon Ser
This function sends a hotplug uevent with a CONNECTOR property. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_sysfs.c | 25 + include/drm/drm_sysfs.h | 1 + 2 files changed, 26 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c

[PATCH v2 0/7] drm: add per-connector hotplug events

2021-06-09 Thread Simon Ser
When a uevent only updates a single connector, add a CONNECTOR property to the uevent. This allows user-space to ignore other connectors when handling the uevent. This is purely an optimization, drivers can still send a uevent without the CONNECTOR property. The CONNECTOR property is already set

Re: [PATCH] drm: display: Remove duplicated argument in dcn31

2021-06-09 Thread Alex Deucher
Applied. Thanks! On Wed, Jun 9, 2021 at 2:48 PM Rodrigo Siqueira wrote: > > On 06/09, Wan Jiabing wrote: > > Fix the following coccicheck warning: > > ./drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c: > > 3539:12-42: duplicated argument to && or || > >

Re: [PATCH] drm: display: Remove duplicate include in dce110

2021-06-09 Thread Alex Deucher
Applied. Thanks! On Wed, Jun 9, 2021 at 2:43 PM Rodrigo Siqueira wrote: > > On 06/08, Wan Jiabing wrote: > > Fix the following checkincludes.pl warning: > > ./drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c > > 35 #include "dce110_hw_sequencer.h" > > 69 #include

Re: [PATCH] drm/amd/display: use ARRAY_SIZE for base60_refresh_rates

2021-06-09 Thread Alex Deucher
Applied. Thanks! On Wed, Jun 9, 2021 at 6:09 AM Jiapeng Chong wrote: > > Use ARRAY_SIZE instead of dividing sizeof array with sizeof an > element. > > Clean up the following coccicheck warning: > > ./drivers/gpu/drm/amd/display/dc/core/dc_resource.c:448:47-48: WARNING: > Use ARRAY_SIZE. > >

Re: [PATCH] drm/amd/display: Fix duplicate included clk_mgr.h

2021-06-09 Thread Alex Deucher
Applied. Thanks! On Wed, Jun 9, 2021 at 6:05 AM Jiapeng Chong wrote: > > Clean up the following includecheck warning: > > ./drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hwseq.c: clk_mgr.h is > included more than once. > > No functional change. > > Reported-by: Abaci Robot > Signed-off-by:

Re: [PATCH 2/2] drm/amd/amdgpu: add instance_number check in amdgpu_discovery_get_ip_version

2021-06-09 Thread Alex Deucher
On Thu, Jun 3, 2021 at 6:42 AM Peng Ju Zhou wrote: > > The original code returns IP version of instantce_0 for every IP. This > implementation may be correct for most of IPs. > > However, for certain IP block (VCN for example), it may have 2 instances and > both of them have the same hw_id, BUT

Re: [PATCH] drm/amdgpu: use adev_to_drm to get drm_device

2021-06-09 Thread Luben Tuikov
That's exactly what I said, but can see that 1/2 of the responses went to amd-gfx, and the other half to brahma ML. Regards, Luben On 2021-06-09 11:38 a.m., Alex Deucher wrote: > On Wed, Jun 9, 2021 at 5:23 AM Guchun Chen wrote: >> Fixes: >> 9faf262c32d3 drm/amdgpu: Add DMA mapping of GTT BOs

Re: [PATCH 1/2] drm/amd/amdgpu: Use IP discovery data to determine VCN enablement instead of MMSCH

2021-06-09 Thread Alex Deucher
On Thu, Jun 3, 2021 at 6:42 AM Peng Ju Zhou wrote: > > From: Bokun Zhang > > In the past, we use MMSCH to determine whether a VCN is enabled or not. > This is not reliable since after a FLR, MMSCH may report junk data. > > It is better to use IP discovery data. > > Signed-off-by: Bokun Zhang >

Re: [RFC PATCH v2 1/8] ext4/xfs: add page refcount helper

2021-06-09 Thread Matthew Wilcox
On Mon, Jun 07, 2021 at 03:42:19PM -0500, Alex Sierra wrote: > +++ b/include/linux/dax.h > @@ -243,6 +243,16 @@ static inline bool dax_mapping(struct address_space > *mapping) > return mapping->host && IS_DAX(mapping->host); > } > > +static inline bool dax_layout_is_idle_page(struct page

Re: [PATCH] drm/amdgpu: use adev_to_drm to get drm_device

2021-06-09 Thread Deucher, Alexander
[Public] We already use the macro everywhere else upstream, so this just makes it consistent. Alex From: amd-gfx on behalf of Felix Kuehling Sent: Wednesday, June 9, 2021 11:32 AM To: Tuikov, Luben ; Chen, Guchun ; amd-gfx@lists.freedesktop.org Subject:

Re: [PATCH] drm/amdgpu: use adev_to_drm to get drm_device

2021-06-09 Thread Felix Kuehling
Am 2021-06-09 um 11:20 a.m. schrieb Luben Tuikov: > On 2021-06-09 10:01 a.m., Felix Kuehling wrote: >> Am 2021-06-09 um 5:23 a.m. schrieb Guchun Chen: >>> Fixes: >>> 9faf262c32d3 drm/amdgpu: Add DMA mapping of GTT BOs >>> 090f3a60d7e8 drm/amdgpu: Use delayed work to collect RAS error counters >> A

Re: [PATCH] drm/amdgpu: use adev_to_drm to get drm_device

2021-06-09 Thread Luben Tuikov
On 2021-06-09 10:01 a.m., Felix Kuehling wrote: > Am 2021-06-09 um 5:23 a.m. schrieb Guchun Chen: >> Fixes: >> 9faf262c32d3 drm/amdgpu: Add DMA mapping of GTT BOs >> 090f3a60d7e8 drm/amdgpu: Use delayed work to collect RAS error counters > A Fixes tag implies that something was broken. However,

Re: [PATCH] drm/amdgpu: use adev_to_drm to get drm_device

2021-06-09 Thread Felix Kuehling
Am 2021-06-09 um 5:23 a.m. schrieb Guchun Chen: > Fixes: > 9faf262c32d3 drm/amdgpu: Add DMA mapping of GTT BOs > 090f3a60d7e8 drm/amdgpu: Use delayed work to collect RAS error counters A Fixes tag implies that something was broken. However, the implementation of adev_to_drm does the exact same

Re: [PATCH] drm/amdgpu: use adev_to_drm to get drm_device

2021-06-09 Thread Alex Deucher
On Wed, Jun 9, 2021 at 5:23 AM Guchun Chen wrote: > > Fixes: > 9faf262c32d3 drm/amdgpu: Add DMA mapping of GTT BOs > 090f3a60d7e8 drm/amdgpu: Use delayed work to collect RAS error counters > drop the fixes lines and say something like use the adev_to_drm() macro for consistency. With that,

Re: [PATCH 0/4] drm: add per-connector hotplug events

2021-06-09 Thread Simon Ser
On Wednesday, June 9th, 2021 at 17:03, Daniel Vetter wrote: > On Wed, Jun 09, 2021 at 10:39:03AM +, Simon Ser wrote: > > When a uevent only updates a single connector, add a CONNECTOR property > > to the uevent. This allows user-space to ignore other connectors when > > handling the uevent.

Re: [PATCH 0/4] drm: add per-connector hotplug events

2021-06-09 Thread Daniel Vetter
On Wed, Jun 09, 2021 at 10:39:03AM +, Simon Ser wrote: > When a uevent only updates a single connector, add a CONNECTOR property > to the uevent. This allows user-space to ignore other connectors when > handling the uevent. This is purely an optimization, drivers can still > send a uevent

RE: [PATCH 2/2] drm/amd/amdgpu: add instance_number check in amdgpu_discovery_get_ip_version

2021-06-09 Thread Zhou, Peng Ju
[AMD Official Use Only] Ping on this series -- Pengju Zhou > -Original Message- > From: Zhou, Peng Ju > Sent: Monday, June 7, 2021 4:13 PM > To: Zhou, Peng Ju ; amd-gfx@lists.freedesktop.org; > Deucher, Alexander > Cc: Zhang, Bokun > Subject: RE: [PATCH 2/2]

Re: [PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+

2021-06-09 Thread Zhu, James
[AMD Official Use Only] Reviewed-by: James Zhu Thanks & Best Regards! James Zhu From: amd-gfx on behalf of Christian König Sent: Tuesday, June 8, 2021 3:23 AM To: Zhang, Boyuan ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH]

[PATCH] drm/amd/display: use ARRAY_SIZE for base60_refresh_rates

2021-06-09 Thread Jiapeng Chong
Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element. Clean up the following coccicheck warning: ./drivers/gpu/drm/amd/display/dc/core/dc_resource.c:448:47-48: WARNING: Use ARRAY_SIZE. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong ---

[PATCH] drm/amd/display: Fix duplicate included clk_mgr.h

2021-06-09 Thread Jiapeng Chong
Clean up the following includecheck warning: ./drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hwseq.c: clk_mgr.h is included more than once. No functional change. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hwseq.c | 1 - 1 file changed, 1

[PATCH] drm/amdgpu: use adev_to_drm to get drm_device

2021-06-09 Thread Guchun Chen
Fixes: 9faf262c32d3 drm/amdgpu: Add DMA mapping of GTT BOs 090f3a60d7e8 drm/amdgpu: Use delayed work to collect RAS error counters Signed-off-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 2 files changed, 2

[PATCH] drm/amdgpu:MI200 PWRBRK Driver change for CRB

2021-06-09 Thread Ashish Pawar
Initial changes were made to add PWRBRK sequence to driver. These are modifications for CRB Signed-off-by: Ashish Pawar --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c

RE: [PATCH] drm/amd/pm: Only primary die supports power data

2021-06-09 Thread Zhang, Hawking
[Public] Reviewed-by: Hawking Zhang Regards, Hawking From: Lazar, Lijo Sent: Wednesday, June 9, 2021 15:09 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Kasiviswanathan, Harish ; Deucher, Alexander ; Quan, Evan ; Feng, Kenneth Subject: [PATCH] drm/amd/pm: Only primary die supports

Re: [PATCH 1/4] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-06-09 Thread Jani Nikula
On Wed, 09 Jun 2021, Simon Ser wrote: > This function sends a hotplug uevent with a CONNECTOR property. > > Signed-off-by: Simon Ser > --- > drivers/gpu/drm/drm_sysfs.c | 25 + > include/drm/drm_sysfs.h | 1 + > 2 files changed, 26 insertions(+) > > diff --git

[PATCH] drm/amd/pm: Only primary die supports power data

2021-06-09 Thread Lazar, Lijo
[Public] On aldebaran, only primary die fetches valid power data. Show power/energy values as 0 on secondary die. Also, power limit should not be set through secondary die. Signed-off-by: Lijo Lazar --- .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c| 57 +++ 1 file changed, 46

[PATCH 4/4] amdgpu: use drm_kms_helper_connector_hotplug_event

2021-06-09 Thread Simon Ser
When updating a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Signed-off-by: Simon Ser --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 ++-- 2 files

[PATCH 0/4] drm: add per-connector hotplug events

2021-06-09 Thread Simon Ser
When a uevent only updates a single connector, add a CONNECTOR property to the uevent. This allows user-space to ignore other connectors when handling the uevent. This is purely an optimization, drivers can still send a uevent without the CONNECTOR property. The CONNECTOR property is already set

[PATCH 3/4] drm/connector: use drm_sysfs_connector_hotplug_event

2021-06-09 Thread Simon Ser
In drm_connector_register, use drm_sysfs_connector_hotplug_event instead of drm_sysfs_hotplug_event, because the hotplug event only updates a single connector. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/4] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-06-09 Thread Simon Ser
This function sends a hotplug uevent with a CONNECTOR property. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_sysfs.c | 25 + include/drm/drm_sysfs.h | 1 + 2 files changed, 26 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c

[PATCH 2/4] drm/probe-helper: add drm_kms_helper_connector_hotplug_event

2021-06-09 Thread Simon Ser
This function is the same as drm_kms_helper_hotplug_event, but takes a connector instead of a device. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_probe_helper.c | 20 include/drm/drm_probe_helper.h | 1 + 2 files changed, 21 insertions(+) diff --git

Re: [PATCH v6 1/9] drm/amd/pm: Add u64 throttler status field to gpu_metrics

2021-06-09 Thread Lazar, Lijo
Series is Reviewed-by: Lijo Lazar On 6/8/2021 8:38 PM, Graham Sider wrote: This patch set adds support for a new ASIC independant u64 throttler status field (indep_throttle_status). Piggybacks off the gpu_metrics_v1_3 bump and similarly bumps gpu_metrics_v2 version (to v2_2) to add field.

[PATCH -next v2] drm/radeon: use list_move instead of list_del/list_add in radeon_vm.c

2021-06-09 Thread Baokun Li
Using list_move() instead of list_del() + list_add() in radeon_vm.c. Reported-by: Hulk Robot Signed-off-by: Baokun Li --- V1->V2: CC mailist drivers/gpu/drm/radeon/radeon_vm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_vm.c

[PATCH -next v2] drm/amdgpu: use list_move instead of list_del/list_add in amdgpu_vm.c

2021-06-09 Thread Baokun Li
Using list_move() instead of list_del() + list_add() in amdgpu_vm.c. Reported-by: Hulk Robot Signed-off-by: Baokun Li --- V1->V2: CC mailist drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH] drm/amdgpu: reset psp ring wptr during ring_create

2021-06-09 Thread YuBiao Wang
[Why] psp ring wptr is not initialized properly in ring_create, which would lead to psp failure after several gpu reset. [How] Set ring_wptr to zero in psp_ring_create. Signed-off-by: YuBiao Wang --- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 1 + 2