Re: [PATCH] drm/amd: Drop abm_level property

2024-03-07 Thread Xaver Hugl
Am Mi., 6. März 2024 um 18:19 Uhr schrieb Mario Limonciello : > So the idea being if the compositor isn't using it we let > power-profiles-daemon (or any other software) take control via sysfs and > if the compositor does want to control it then it then it writes a DRM > cap and we destroy the

Re: [PATCH] drm/amd: Drop abm_level property

2024-03-07 Thread Xaver Hugl
Like already mentioned in the power profiles daemon repository, I don't think this makes sense. This is a display setting, which compositors have interest in controlling, for example to: - disable it in a bright environment, because afaiu it reduces the maximum screen brightness - disable it

Re: [PATCH] drm/amd: Drop abm_level property

2024-03-06 Thread Mario Limonciello
On 3/6/2024 12:59, Harry Wentland wrote: On 2024-03-06 13:02, Mario Limonciello wrote: On 3/6/2024 12:00, Xaver Hugl wrote: Am Mi., 6. März 2024 um 18:19 Uhr schrieb Mario Limonciello : So the idea being if the compositor isn't using it we let power-profiles-daemon (or any other software)

Re: [PATCH] drm/amd: Drop abm_level property

2024-03-06 Thread Harry Wentland
On 2024-03-06 13:02, Mario Limonciello wrote: > On 3/6/2024 12:00, Xaver Hugl wrote: >> Am Mi., 6. März 2024 um 18:19 Uhr schrieb Mario Limonciello >> : >>> So the idea being if the compositor isn't using it we let >>> power-profiles-daemon (or any other software) take control via sysfs and >>>

Re: [PATCH] drm/amd: Drop abm_level property

2024-03-06 Thread Mario Limonciello
On 3/6/2024 12:00, Xaver Hugl wrote: Am Mi., 6. März 2024 um 18:19 Uhr schrieb Mario Limonciello : So the idea being if the compositor isn't using it we let power-profiles-daemon (or any other software) take control via sysfs and if the compositor does want to control it then it then it writes

Re: [PATCH] drm/amd: Drop abm_level property

2024-03-06 Thread Mario Limonciello
On 3/6/2024 11:08, Xaver Hugl wrote: Like already mentioned in the power profiles daemon repository, I don't think this makes sense. This is a display setting, which compositors have interest in controlling, for example to: - disable it in a bright environment, because afaiu it reduces the

Re: [PATCH] drm/amd: Drop abm_level property

2024-02-19 Thread Christian König
Am 16.02.24 um 16:33 schrieb Mario Limonciello: This vendor specific property has never been used by userspace software and conflicts with the panel_power_savings sysfs file. That is a compositor and user could fight over the same data. Fixes: f97e4303da16 ("drm/amd/display: add

Re: [PATCH] drm/amd: Drop abm_level property

2024-02-16 Thread Harry Wentland
On 2024-02-16 10:33, Mario Limonciello wrote: > This vendor specific property has never been used by userspace > software and conflicts with the panel_power_savings sysfs file. > That is a compositor and user could fight over the same data. > > Fixes: f97e4303da16 ("drm/amd/display: add

[PATCH] drm/amd: Drop abm_level property

2024-02-16 Thread Mario Limonciello
This vendor specific property has never been used by userspace software and conflicts with the panel_power_savings sysfs file. That is a compositor and user could fight over the same data. Fixes: f97e4303da16 ("drm/amd/display: add panel_power_savings sysfs entry to eDP connectors")